[#27940] - [4.0] Adaptive Accessibility Menu
- Fixed in Code Base
- 10 Mar 2020
- Medium
- Build: 4.0-dev
- # 27940
- Diff
- brianteeman:ranbuch
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Read more about the plugin here https://ranbuch.github.io/accessibility/
This was previously at #24112 but there was a bug upstream which has now been fixed
Feature configuration options have not been added at this point - not sure if we should.
This can be configured to be site, administrator or both
To test you will need to
- apply the patch
- composer install
- npm i
- Discover the plugin
- Enable the plugin
Supports RTL
Previous Comment
- Such a plugin is useful and may improve the accessibility of the site, provided that it works well. Brian has chosen a very good script that doesn't cause the errors that widgets of this type cause.
- The plugin does not solve the problems of people with disabilities. People with disabilities use specialised tools (screen readers, screen magnifiers, braille embossers… etc.). But it improves usability for the elderly, people with visual impairments, people with cognitive problems.
- E.g. a blind person will use a screen reader and not the option to change text to speech. But this is a very good solution for the elderly, for people who have difficulty concentrating, and also for those who cannot read at the moment.
- Text enlargement is very useful for many seniors and people who see less well. Such people often do not know about the possibilities of the browser and like to use such tools.
- The contrast version will not replace the correct contrasts on the website. But it can be helpful for people who have weaker eyesight or for people who browse the site, for example in a sunny place.
- WCAG does not require the links to be underlined (they must be highlighted). But underlined links can improve accessibility for visually impaired people or for people who have difficulty concentrating.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Repository NPM Change Front End Plugins |
| Labels |
Added:
?
NPM Resource Changed
?
?
|
||
it looks good, I only would use WebAsset
I can make a pull, but a bit later
I have tested a bit, and noticed the font size scaling works "not equal" for all blocks,
I think it is due to how font size coded in the template style
TEXT SIZE MANIPULATION APPROACHES
If text increase / decrease isn't working for your size your probablly not using responsive font size units (sutch as em, rem etc.).
In that case you can initialize the accessibility tool like this:
new Accessibility({textPixelMode: true})
In that case you can initialize the accessibility tool like this:
new Accessibility({textPixelMode: true})
Yeah, but it have a huge performance drawback, I just tried.
It is better if someone review hardcoded font sizes in the template, after the plugin will be merged
It is better if someone review hardcoded font sizes in the template, after the plugin will be merged
I agree
thanks for the web asset stuff - I will test and merge that soon
hm, no, sorry for misleading, the fonts is not hardcoded,
I see the plugin manipulate font size of <body>, that not always correct,
would be better if it can do with <html>
All fonts in template are in rem that is allow you to change font size in browser settings, that how browser Accessibility works (see font size in browser settings)
Can you tell me where you are seeing fonts not resizing
I tried administrator/index.php?option=com_plugins&view=plugins
the menu "resizes", but the content in table and in filters are not,
also if open any plugin to edit
but resizing work, if I change font size in browser setting
bugger - confirmed
Now uses web asset
@Fedik the good news is that its nothing to do with the script and it is some sort of bug with the current atum template. It works perfectly with the template @angieradtke is working on
bug with the current atum template
There no bug in template, the script use incorrect approach.
Check section "Base font size and accessibility"
https://betterwebtype.com/articles/2019/06/16/5-keys-to-accessible-web-typography/
But if the template will change all font size to em then it will work as is, of course. That also fine.
| Category | Administration Language & Strings Repository NPM Change Front End Plugins | ⇒ | Administration Language & Strings Repository Libraries NPM Change Front End Plugins |
| Title |
|
||||||
btw, I have open an issue about font-size bug, in their repository.
Would be nice if they can fix it on their side.
he fixed the font issue, can you try update script here to 3.0.9
awesome - will do that this afternoon
| Labels |
Removed:
?
|
||
updated the version
I have tested this item
now it works much better
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27940.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27940.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27940.
btw a bit ugly when you invert colours ...
is this configurable ?
| Labels |
Added:
?
|
||
- please remove rtc as there is no sql yet
- invert colours is supposed to look like that. its not for your eyesight
Quy
- | Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
| Category | Administration Language & Strings Repository NPM Change Front End Plugins Libraries | ⇒ | SQL Administration com_admin Postgresql Language & Strings Repository Installation Libraries NPM Change Front End Plugins |
sql files now added and this PR is complete
conflicts resolved
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27940.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27940.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27940.
| Labels |
Added:
?
|
||
Can you merge through 4.0-dev please so I can see the green tick of goodness please :)
Other than a boring piece of codestyle this looks good to me
ta. i'll keep kicking it until it goes green
all green now
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-10 13:45:37 |
| Closed_By | ⇒ | wilsonge |
And all merged - thanks!
Yay. Thanks
@Fedik I fixed the bits I wanted help on. Well it works but maybe it could be better code.