? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
15 Feb 2020

Pull Request for Issue #27921

Summary of Changes

The associations button in the article edit form triggered the editAssocations task. That task invoked a save method in the model and then redirected to the association manager.
Unfortunately that save method bypassed everything done in the controller->save method. Resulting beside other potential issues in the issue above where the dateformat wasn't properly translated back.

This PR moves the code from the editAssociations method to the save method with a conditional on the active task.
in the controller, the "editAssociations" task is registered as a variant of the save method.

I have left the old "editAssociations" methods in the controller and model to keep B/C and added a deprecation note for 5.0.

Testing Instructions

  • Test in the administrator backend using a language that doesn't use the regular english date format YYYY-MM-DD, for example german or russian.
  • In a multilingual site, create an article assigned to a specific language.
  • After saving the article, click on the "Associations" button in the edit form.
  • It will redirect to the Associations Manager. In the new side-by-side form, check the created date of the article.

Expected result

Date is still there

Actual result

Date is empty

Documentation Changes Required

None

avatar Bakual Bakual - open - 15 Feb 2020
avatar Bakual Bakual - change - 15 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2020
Category Libraries
avatar richard67
richard67 - comment - 15 Feb 2020

@sanek4life Please thest. I'll test too tomorrow.

avatar infograf768
infograf768 - comment - 16 Feb 2020

I have tested this item successfully on e89d1f5

?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941.

avatar infograf768 infograf768 - test_item - 16 Feb 2020 - Tested successfully
avatar viocassel
viocassel - comment - 16 Feb 2020

I have tested this item successfully on e89d1f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941.

avatar viocassel viocassel - test_item - 16 Feb 2020 - Tested successfully
avatar infograf768 infograf768 - change - 16 Feb 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 16 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941.

avatar infograf768 infograf768 - change - 16 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-16 07:48:29
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 16 Feb 2020
avatar infograf768 infograf768 - merge - 16 Feb 2020
avatar infograf768
infograf768 - comment - 16 Feb 2020

Thanks @Bakual

avatar sanek4life
sanek4life - comment - 16 Feb 2020

@sanek4life Please thest. I'll test too tomorrow.

It finally works!

изображение

avatar infograf768
infograf768 - comment - 16 Feb 2020

Already merged. ;) Will be available in next release 3.9.16.

avatar sanek4life
sanek4life - comment - 16 Feb 2020

Already merged. ;) Will be available in next release 3.9.16.

What to do with other articles that were created before 3.9.16? Have to set the Created Date again and Save it?

avatar Bakual
Bakual - comment - 16 Feb 2020

What to do with other articles that were created before 3.9.16? Have to set the Created Date again and Save it?

Yep, unfortunately there is no other way as the data is lost.

Thanks for being stubborn with this issue. It was quite a bit hidden ?

avatar infograf768
infograf768 - comment - 10 Mar 2020

@Bakual
This broke loading com_associations for menu items when using the button

avatar rvbgnu
rvbgnu - comment - 10 Mar 2020

Issue open #28310

Add a Comment

Login with GitHub to post a comment