How can you say that this change will not break any existing code

How can you say that this change will not break any existing code

it make changes only when label is layout builder else it will make no change to code.hence everything should run as good as they were running before

I suggest that you read the code again. Because the code in the PR absolutely changes existing behaviour

I suggest that you read the code again. Because the code in the PR absolutely changes existing behaviour

sorry my bad. made right again

made code right again

I have no idea why you are doing this but as the value of the label is coming from

$label = Text::_($fieldSet->label);

it is being translated and therefore your code wont work

I have no idea why you are doing this but as the value of the label is coming from

$label = Text::_($fieldSet->label);

it is being translated and therefore your code wont work

I don't know why but the code is working already tried it in pagebuilder repo. i think when
$label = Text::_($fieldSet->label); is translated to "layout builder" string matching take place. in this block of code first $label value is set then condition is checked therefore it is working. my main aim is to restrict this

@Quy removed class thanks for suggestion i forget to remove.

As soon as the label is translated or there is a language override then your code obviously wont work

1. You would need to compare with the constant not the value
2. Are you sure that reusing this params layout is the best option - wouldn't it be better to have your own layout to use for the layout builder

1 you are right I'm sorry I forget joomla uses multi language I will work into it.
2 I don't think we should make new params layou for layout builder. We should never repeat our code. All work can be done by just adding one condition why should we make new layout? It will increase code. If still it is necessary please explain.

@brianteeman hey i am using id as a constant for layout builder. while defining fileldset for layout builder we will need id. what you say? am i in right direction please guide.

The entire point of layouts is that they are single purpose.

The entire point of layouts is that they are single purpose.

ok

@ravisaxena23 Please advise status.

@Quy I'm trying to understand code more better. And thinking a way to make changes possible without changing any joomla core file. For now we can close this pr. I will try something new in pagebuilder repo. If it works we don't have to make changes in Joomla core.
I'm open for any suggestion and help. If there is any better way to do things please explain to me.

Let’s close for now. If you come up with a fix, this can be reopened. Thanks.