Feeling Lucky
NPM Resource Changed
?
?
?
[#27938] - fixed error of js errors in console
- Closed
- 28 Dec 2020
- Medium
- Build: 4.0-dev
- # 27938
- Diff
- Subhang23:jserror
- Success Hound Smells good to me. Woof! Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27606 .
Summary of Changes
Since the the eventListener might be used later I have wrapped it in a try catch block
Testing Instructions
Expected result
There to be no error in the console
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Fedik
- comment
- 16 Feb 2020
sorry, the fix are wrong,
to make a correct fix you have to analyse what cause an error, first
SharkyKZ
- comment
- 16 Feb 2020
Fields have their own batch script https://github.com/joomla/joomla-cms/blob/0a12b92a93630435f7ca0c5129f48a11d875ed57/build/media_source/com_fields/js/admin-fields-default-batch.es6.js. We can either move relevant part of the code to batch-language.js and remove that script or start loading batch-language.js only where it's actually used.
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-28 19:45:45 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
@Quy is this what was intended?