[#27915] - [4.0] Normalize JS in All Categories views
- Fixed in Code Base
- 29 Feb 2020
- Medium
- Build: 4.0-dev
- # 27915
- Diff
- SharkyKZ:j4/js/categories-default
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #26695.
Summary of Changes
Normalizes categories-default.js in com_content, com_contactandcom_newsfeeds`, fixing several issues in All Categories views.
Testing Instructions
Create categories with child categories for mentioned components.
Go to List All Categories views in frontend.
Click the + button to expand categories.
Check that plus icon changes to minus and that aria-label attribute of the button updates.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End com_contact com_content com_newsfeeds |
@SniperSister @zero-24 can you look at RIPs here please
@infograf768 Yes, JS files are now identical. I just have no idea where to put the single reusable file.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27915.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27915.
Yes, JS files are now identical. I just have no idea where to put the single reusable file.
place it under media/com_categories, name it somehow useful categories-shared-random-stuff.js and use it in other components
| Labels |
Added:
?
|
||
Do we need here another round of tests or can RTC stay?
| Status | Ready to Commit | ⇒ | Pending |
Set back to Pending, I guess. The tracker won't let me remove RTC label..
Do you like to have tests here? If so, could you please resolve the conflicts?
| Labels |
Added:
Conflicting Files
Removed: ? |
||
Conflicts solved.
I have tested this Patch.
- git fetch origin pull/27915/head:j4/js/categories-default
- git checkout j4/js/categories-default
- No new install but I run npm ci.
- I created categories with child categories for com_content, com_contact and com_newsfeed.
- I created menu items that shows emty categories.
- I could open and close the all views in the front end.
I tested with the current 4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27915.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-29 23:42:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks! Nice work :)
I have tested this item✅ successfully on 391d6a9
great stuff - accessibility is great as well - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27915.