NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
13 Feb 2020

Pull Request for Issue #27824

Summary of Changes

Makes highlighted taxonomy legible
Increase fontsize in badge as well as padding
Add dark color to highlighted terms in badge and increase padding

Testing Instructions

Display a smartsearch module in frontend.
Use category name as keyword

Before patch

Screen Shot 2020-02-13 at 09 51 12

After patch

Screen Shot 2020-02-13 at 09 00 53

avatar infograf768 infograf768 - open - 13 Feb 2020
avatar infograf768 infograf768 - change - 13 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2020
Category Repository NPM Change
avatar infograf768 infograf768 - change - 13 Feb 2020
The description was changed
avatar infograf768 infograf768 - edited - 13 Feb 2020
avatar brianteeman
brianteeman - comment - 13 Feb 2020

I have tested this item successfully on 336cd9a

and the contrast is accessible - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27914.

avatar brianteeman brianteeman - test_item - 13 Feb 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 13 Feb 2020

Made as shown under Testing Instructions & can confirm Before patch.
I'm afraid (:- but after: Apply patch, I get: The file marked for modification does not exist: build/media_source/com_finder/css/finder.css
Maybe missing something?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27914.
Edit: Ah I see now, NPM needed.

avatar Quy
Quy - comment - 13 Feb 2020

I have tested this item successfully on 336cd9a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27914.

avatar Quy Quy - test_item - 13 Feb 2020 - Tested successfully
avatar Quy Quy - change - 13 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27914.

avatar Quy
Quy - comment - 13 Feb 2020

@ChristineWk When a PR is labelled NPM Resource Changed, then it cannot be tested with the nightly builds.

avatar ChristineWk
ChristineWk - comment - 13 Feb 2020

@Quy Yes I know - but I saw it too late. Sorry.

avatar rdeutz rdeutz - close - 16 Feb 2020
avatar rdeutz rdeutz - merge - 16 Feb 2020
avatar rdeutz rdeutz - change - 16 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-16 08:52:47
Closed_By rdeutz
Labels Added: NPM Resource Changed ?

Add a Comment

Login with GitHub to post a comment