Feeling Lucky
NPM Resource Changed
?
?
[#27884] - [4.0] Replace HTMLHelper to WebAsset for media/vendor/ assets
- Fixed in Code Base
- 29 Feb 2020
- Medium
- Build: 4.0-dev
- # 27884
- Diff
- Fedik:asset-replaces1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
The patch replaces use HTMLHelper::_('script/stylesheet') that loads a files from media/vendor/ folder, to use WebAsset
Testing Instructions
Apply patch, run npm install.
And check that everything still works, the changes here affects next parts:
- history compare view
- admin mod_menu
- template style colors field
- template edit
- skipTo
- crop action in media manager
- chosen (why do we still have it? :) ) - I did not found where it used
- draggable - drag sorting - can test in menu items table
Expected result
All works
Actual result
All works
Documentation Changes Required
nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory com_templates Modules Repository NPM Change Layout Libraries Front End Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
jwaisner
- comment
- 28 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27884.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 28 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27884.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-29 08:28:27 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 1b4d5d1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27884.