? ? Pending

User tests: Successful: Unsuccessful:

avatar Subhang23
Subhang23
10 Feb 2020

…modal

Pull Request for Issue #27823 .

Summary of Changes

Styled the close button in the modal of add modules

Testing Instructions

Shift to any RTL language and view the modal of add modules

Actual result

Screenshot from 2020-02-10 23-29-08

avatar Subhang23 Subhang23 - open - 10 Feb 2020
avatar Subhang23 Subhang23 - change - 10 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2020
Category Administration Templates (admin)
avatar Subhang23
Subhang23 - comment - 10 Feb 2020

Could someone explain why the build is failing?

avatar infograf768
infograf768 - comment - 10 Feb 2020

Nothing related to your patch. But there are some cs issues and I am not sure you chose the best solution.
Will look tomorrow.

avatar infograf768
infograf768 - comment - 11 Feb 2020

I don't think we should do it as you propose. See #27823 (comment)

Your patch gives
Screen Shot 2020-02-11 at 08 37 01

Mine gives
Screen Shot 2020-02-11 at 09 00 42

As you can see, the text is placed OK, similar to LTR and not near to the icon
Screen Shot 2020-02-11 at 08 29 32

This is a .diff I made here:

diff --git a/administrator/templates/atum/scss/blocks/_modals.scss b/administrator/templates/atum/scss/blocks/_modals.scss
index 4975528..8246c79 100644
--- a/administrator/templates/atum/scss/blocks/_modals.scss
+++ b/administrator/templates/atum/scss/blocks/_modals.scss
@@ -66,5 +66,4 @@
     background-color: var(--danger);
     color: hsla(0, 0%, 100%, .9);
-
     display: inline-block;
     width: 2.375rem;
@@ -72,4 +71,8 @@
     margin: 0 16px 0 -22px;
     line-height: 2.375rem;
+
+    [dir=rtl] & {
+       margin: 0 -22px 0 16px;
+    }
   }
 
@@ -81,5 +84,4 @@
     background-color: var(--success);
     color: hsla(0, 0%, 100%, .9);
-
     display: inline-block;
     width: 2.375rem;
@@ -87,6 +89,9 @@
     margin: 0 16px 0 -22px;
     line-height: 2.375rem;
-  }
 
+    [dir=rtl] & {
+       margin: 0 -22px 0 16px;
+    }
+  }
 }

The whole file would be
_modals.scss.zip

Could you correct this PR, or shall we close it and I will make a new one?

avatar Subhang23
Subhang23 - comment - 11 Feb 2020

@infograf768 I will correct this PR

avatar Subhang23 Subhang23 - change - 11 Feb 2020
Labels Added: ?
avatar infograf768 infograf768 - test_item - 11 Feb 2020 - Not tested
avatar infograf768 infograf768 - test_item - 11 Feb 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 11 Feb 2020

I have tested this item successfully on 288ec4e

thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27883.

avatar Quy Quy - test_item - 11 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 11 Feb 2020

I have tested this item successfully on 288ec4e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27883.

avatar Quy Quy - change - 11 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27883.

avatar infograf768 infograf768 - change - 11 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-11 17:14:14
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 11 Feb 2020
avatar infograf768 infograf768 - merge - 11 Feb 2020
avatar infograf768
infograf768 - comment - 11 Feb 2020

thanks

Add a Comment

Login with GitHub to post a comment