? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
10 Feb 2020

Currently, a custom admin menu can't have a quicktask icon like used in the default menu.
image

Summary of Changes

This adds this feature to the custom menuitem "List All Articles".
After applying this PR, you'll see a new tab "Options" with a new parameter
image

This PR also simplyfies the code related to the quicktask a bit as we don't need two parameters menu-quicktask and menu-quicktask-link. I've merged that into one switcher parameter which when enabled holds the quicktask link directly.

I've also removed the quicktask parameter from the categories menuitem. First reason is that it didn't work to begin with, second one is that the link was hardcoded to com_content, but the menuitem allows to select the "category scope". So even if I fixed the parameter in the XML, it still wouldn't work as expected. So I removed it.

Testing Instructions

Create a custom admin menu and add a "List All Articles" menuitem to it.
Check options and how the menuitem appears.

Expected result

An option to show/hide the "Add New" button
Depending on setting, the "Add New" button appears

Actual result

No way of using that feature in the custom menu.

Documentation Changes Required

None

avatar Bakual Bakual - open - 10 Feb 2020
avatar Bakual Bakual - change - 10 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2020
Category Administration com_categories com_content com_menus Modules
avatar Bakual Bakual - change - 10 Feb 2020
Labels Added: ?
bf501e7 11 Feb 2020 avatar Bakual CS
f2ec16b 11 Feb 2020 avatar Bakual CS
avatar roland-d roland-d - test_item - 11 Feb 2020 - Tested successfully
avatar roland-d
roland-d - comment - 11 Feb 2020

I have tested this item successfully on 2c2d30a

Before applying the patch it was not possible to add the + symbol to add a new article. After applying the patch the option showed up in the menu item and the + is shown if activated or hidden when not activated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27885.

avatar brianteeman
brianteeman - comment - 11 Feb 2020

@roland-d a bit confused because the ability to to add the + symbol to add a new article is nothing to do with this PR. This PR is about adding the + to your own component

avatar brianteeman
brianteeman - comment - 11 Feb 2020

oops - commented on wrong issue

avatar jwaisner jwaisner - test_item - 11 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Feb 2020

I have tested this item successfully on 2c2d30a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27885.

avatar jwaisner jwaisner - change - 11 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 11 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27885.

avatar rdeutz rdeutz - change - 12 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-12 08:20:58
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 12 Feb 2020
avatar rdeutz rdeutz - merge - 12 Feb 2020

Add a Comment

Login with GitHub to post a comment