?
avatar SharkyKZ
SharkyKZ
6 Feb 2020

Steps to reproduce the issue

Use Smart Search in frontend. Use category name as keyword.

Expected result

Readable text.

Actual result

Screenshot_2020-02-06 Smart Search

avatar SharkyKZ SharkyKZ - open - 6 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Feb 2020
avatar infograf768
infograf768 - comment - 6 Feb 2020

The issue comes from the use of badge-secondary and span.highlight
the text is white and the highlight is yellow, so no contrast.

Can be solved to get
Screen Shot 2020-02-06 at 10 45 40

By modifying the css to

span.highlight {
background-color: #ffffcc;
font-weight: bold;
padding: 1px 4px;
color: #343a40; // color added
}

But also, obviously the .badge text is much too small and its padding is not enough.
By modifying the .badge css to use

padding: 0.45em 0.8em;
font-size: 85%;

we would get
badge

What do you think?

avatar infograf768
infograf768 - comment - 6 Feb 2020

Will make PR later.

avatar jwaisner jwaisner - change - 8 Feb 2020
Status New Confirmed
Build staging 4.0dev
avatar brianteeman
brianteeman - comment - 12 Feb 2020

@infograf768 did you forget?

avatar infograf768
infograf768 - comment - 12 Feb 2020

I was concentrated on the damned svg...
Will do tomorrow.

avatar brianteeman
brianteeman - comment - 12 Feb 2020

NP. just shout if not and I can do it

avatar infograf768
infograf768 - comment - 13 Feb 2020

Closing as we have a patch.
#27914

avatar infograf768 infograf768 - change - 13 Feb 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-02-13 08:54:29
Closed_By infograf768
avatar infograf768 infograf768 - close - 13 Feb 2020

Add a Comment

Login with GitHub to post a comment