?
avatar Subhang23
Subhang23
6 Feb 2020

Steps to reproduce the issue

Switch to a rtl language (Ex:-Persian)
Go to dashboard and press on the add modules button
You can notice the icon for close is not properly placed

Expected result

The icon should be placed more to the right

Actual result

Screenshot from 2020-02-06 13-26-02

System information (as much as possible)

Ubuntu 18.04(Virtual Machine) PHP-7.2.24

Additional comments

avatar Subhang23 Subhang23 - open - 6 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Feb 2020
avatar Subhang23
Subhang23 - comment - 6 Feb 2020

I would like to work on this

avatar Subhang23 Subhang23 - change - 6 Feb 2020
The description was changed
avatar Subhang23 Subhang23 - edited - 6 Feb 2020
avatar infograf768
infograf768 - comment - 6 Feb 2020

It should be easy
we have for rtl

 .btn.btn-danger [class*=" fa-"],
  .btn.btn-danger [class*=" icon-"],
  .btn.btn-danger [class^=fa-],
  .btn.btn-danger [class^=icon-],
  .btn.btn-danger span {
    background-color: var(--danger);
    color: hsla(0, 0%, 100%, .9);

    display: inline-block;
    width: 2.375rem;
    height: 100%;
    margin: 0 16px 0 -22px;
    line-height: 2.375rem;
  }

  .btn.btn-success [class*=" fa-"],
  .btn.btn-success [class*=" icon-"],
  .btn.btn-success [class^=fa-],
  .btn.btn-success [class^=icon-],
  .btn.btn-success span {
    background-color: var(--success);
    color: hsla(0, 0%, 100%, .9);

    display: inline-block;
    width: 2.375rem;
    height: 100%;
    margin: 0 16px 0 -22px;
    line-height: 2.375rem;
  }

We have to add a [dir=rtl] & { where the margin is
margin: 0 -22px 0 16px;

for both

avatar richard67 richard67 - change - 6 Feb 2020
Status New Confirmed
avatar infograf768
infograf768 - comment - 7 Feb 2020

@Subhang23
Are you going to make this specific PR?

avatar Subhang23
Subhang23 - comment - 7 Feb 2020

I will be doing it. I actually made a mistake with the branches.

avatar infograf768
infograf768 - comment - 7 Feb 2020

Thanks. Please limit your changes to this issue and please test #27841 which solves mobile alignment.

avatar Subhang23
Subhang23 - comment - 10 Feb 2020

Thanks. Please limit your changes to this issue and please test #27841 which solves mobile alignment.

@infograf768 I don't understand what I should do here.

avatar Quy
Quy - comment - 10 Feb 2020

See PR #27883

avatar Quy Quy - change - 10 Feb 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-02-10 18:32:25
Closed_By Quy
avatar Quy Quy - close - 10 Feb 2020

Add a Comment

Login with GitHub to post a comment