Feeling Lucky
?
[#27823] - Fixing of CSS styling in the close button of add modules for any rtl language
- Closed
- 10 Feb 2020
- Medium
- Build: staging
- # 27823
Steps to reproduce the issue
Switch to a rtl language (Ex:-Persian)
Go to dashboard and press on the add modules button
You can notice the icon for close is not properly placed
Expected result
The icon should be placed more to the right
Actual result
System information (as much as possible)
Ubuntu 18.04(Virtual Machine) PHP-7.2.24
Additional comments
joomla-cms-bot
- | Labels |
Added:
?
|
||
infograf768
- comment
- 6 Feb 2020
It should be easy
we have for rtl
.btn.btn-danger [class*=" fa-"],
.btn.btn-danger [class*=" icon-"],
.btn.btn-danger [class^=fa-],
.btn.btn-danger [class^=icon-],
.btn.btn-danger span {
background-color: var(--danger);
color: hsla(0, 0%, 100%, .9);
display: inline-block;
width: 2.375rem;
height: 100%;
margin: 0 16px 0 -22px;
line-height: 2.375rem;
}
.btn.btn-success [class*=" fa-"],
.btn.btn-success [class*=" icon-"],
.btn.btn-success [class^=fa-],
.btn.btn-success [class^=icon-],
.btn.btn-success span {
background-color: var(--success);
color: hsla(0, 0%, 100%, .9);
display: inline-block;
width: 2.375rem;
height: 100%;
margin: 0 16px 0 -22px;
line-height: 2.375rem;
}
We have to add a [dir=rtl] & { where the margin is
margin: 0 -22px 0 16px;
for both
richard67
- | Status | New | ⇒ | Confirmed |
infograf768
- comment
- 7 Feb 2020
@Subhang23
Are you going to make this specific PR?
Subhang23
- comment
- 7 Feb 2020
I will be doing it. I actually made a mistake with the branches.
Subhang23
- comment
- 10 Feb 2020
Thanks. Please limit your changes to this issue and please test #27841 which solves mobile alignment.
@infograf768 I don't understand what I should do here.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-10 18:32:25 |
| Closed_By | ⇒ | Quy |
I would like to work on this