[#27825] - [4.0] Newsfeed Definition List
- Fixed in Code Base
- 9 Feb 2020
- Medium
- Build: 4.0-dev
- # 27825
- Diff
- brianteeman:newsfeed
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The child count of items is using a definition list. This is completely the wrong markup to use as a number is not the description of the term in this use.
This PR changes it to a span exactly the same as every other use of show_cat_items
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_newsfeeds |
@brianteeman I've tried to test but I did not get the questionable markup (before applying the PR of course). What am I doing wrong? Was checking the category view for newsfeeds category after having installed testing sample data and switched on all show this or that options in the component settings.
as it is in the child you need to make sure you add a subcategory and create a feed in that subcategory
Thanks, will try soon.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27825.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27825.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-09 15:46:24 |
| Closed_By | ⇒ | Quy | |
| Labels | |||
thx
I have tested this item✅ successfully on 6e97fd3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27825.