? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
8 Jan 2014

This PR fixes two issues related to cookie settings in global configuration

  • The languagefilter and logout plugins were looking for the config parameters config.cookie_domain and config.cookie_path. The correct call is without the config. part.
  • There were some places where the cookie_path parameter didn't fetch the correct default value /. Together with SEF turned on, this could result in cookies only being valid for a submenu of the page since the path was taken from the current URL instead from root.
avatar Bakual Bakual - open - 8 Jan 2014
avatar infograf768
infograf768 - comment - 3 Jun 2014

Indeed, obvious error.

avatar infograf768 infograf768 - reference | 4c1b1dc - 3 Jun 14
avatar infograf768 infograf768 - merge - 3 Jun 2014
avatar infograf768 infograf768 - close - 3 Jun 2014
avatar infograf768 infograf768 - change - 3 Jun 2014
Description <p>This PR fixes two issues related to cookie settings in global configuration</p> <ul> <li>The languagefilter and logout plugins were looking for the config parameters <code>config.cookie_domain</code> and <code>config.cookie_path</code>. The correct call is without the <code>config.</code> part.</li> <li>There were some places where the <code>cookie_path</code> parameter didn't fetch the correct default value <code>/</code>. Together with SEF turned on, this could result in cookies only being valid for a submenu of the page since the path was taken from the current URL instead from root.</li> </ul> <p>This PR fixes two issues related to cookie settings in global configuration</p> <ul class="task-list"> <li>The languagefilter and logout plugins were looking for the config parameters <code>config.cookie_domain</code> and <code>config.cookie_path</code>. The correct call is without the <code>config.</code> part.</li> <li>There were some places where the <code>cookie_path</code> parameter didn't fetch the correct default value <code>/</code>. Together with SEF turned on, this could result in cookies only being valid for a submenu of the page since the path was taken from the current URL instead from root.</li> </ul>
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-03 10:26:10
avatar infograf768 infograf768 - close - 3 Jun 2014
avatar Bakual Bakual - head_ref_deleted - 3 Jun 2014

Add a Comment

Login with GitHub to post a comment