Joomla! Issue Tracker | Joomla! CMS #2774 - [#] Fix spinner not appearing while installing language

Closed
9 Jan 2014
Medium
Build: staging
# 2774
Diff
javigomez:fix_spinner_in_language
Foreign ID 33106

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

javigomez
9 Jan 2014

Description

This old change make this javascript to stop working: 08658c3 because the ID selector (#) was removed.

JoomlaCode Issue

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33106&start=0

Testing instructions

Do all Joomla Install steps until the last sceen, and in the same installer go to "install languages"

Choose several languages from the list and click next

When you apply the patch you should be able to see a spinner with a text saying that the installation may take several seconds (without the patch this was not working):

9f386d3 9 Jan 2014

[#] Fix spinner not appearing while installing language

javigomez - open - 9 Jan 2014

javigomez - change - 9 Jan 2014

The description was changed

Description	<h2>Description</h2> <p>This old change make this javascript to stop working: <a href="https://github.com/joomla/joomla-cms/commit/08658c34cbc45db8e578277a468517a756e2846d" class="commit-link"><tt>08658c3</tt></a> because the ID selector (#) was removed.</p> <h2>Testing instructions</h2> <ul> <li>Do all Joomla Install steps until the last sceen, and in the same installer go to "install languages"</li> </ul><p><a href="https://f.cloud.github.com/assets/1375475/1876681/5aa5a536-7916-11e3-873e-1ee2685168e5.png" target="_blank"><img src="https://f.cloud.github.com/assets/1375475/1876681/5aa5a536-7916-11e3-873e-1ee2685168e5.png" alt="screen shot 2014-01-09 at 11 11 28" style="max-width:100%;"></a></p> <ul> <li>Choose several languages from the list and click next</li> </ul><p><a href="https://f.cloud.github.com/assets/1375475/1876691/8622414c-7916-11e3-94b2-f05cff3efcc6.png" target="_blank"><img src="https://f.cloud.github.com/assets/1375475/1876691/8622414c-7916-11e3-94b2-f05cff3efcc6.png" alt="screen shot 2014-01-09 at 11 13 29" style="max-width:100%;"></a></p> <ul> <li>When you apply the patch you should be able to see a spinner with a text saying that the installation may take several seconds (without the patch this was not working):</li> </ul><p><a href="https://f.cloud.github.com/assets/1375475/1876706/b32c065a-7916-11e3-8273-0c568f70e284.png" target="_blank"><img src="https://f.cloud.github.com/assets/1375475/1876706/b32c065a-7916-11e3-8273-0c568f70e284.png" alt="screen shot 2014-01-09 at 11 13 40" style="max-width:100%;"></a></p>	⇒	<h2>Description</h2> <p>This old change make this javascript to stop working: <a href="https://github.com/joomla/joomla-cms/commit/08658c34cbc45db8e578277a468517a756e2846d" class="commit-link"><tt>08658c3</tt></a> because the ID selector (#) was removed.</p> <h2>JoomlaCode Issue</h2> <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33106&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33106&start=0</a> </p> <h2>Testing instructions</h2> <ul> <li>Do all Joomla Install steps until the last sceen, and in the same installer go to "install languages"</li> </ul><p><a href="https://f.cloud.github.com/assets/1375475/1876681/5aa5a536-7916-11e3-873e-1ee2685168e5.png" target="_blank"><img src="https://f.cloud.github.com/assets/1375475/1876681/5aa5a536-7916-11e3-873e-1ee2685168e5.png" alt="screen shot 2014-01-09 at 11 11 28" style="max-width:100%;"></a></p> <ul> <li>Choose several languages from the list and click next</li> </ul><p><a href="https://f.cloud.github.com/assets/1375475/1876691/8622414c-7916-11e3-94b2-f05cff3efcc6.png" target="_blank"><img src="https://f.cloud.github.com/assets/1375475/1876691/8622414c-7916-11e3-94b2-f05cff3efcc6.png" alt="screen shot 2014-01-09 at 11 13 29" style="max-width:100%;"></a></p> <ul> <li>When you apply the patch you should be able to see a spinner with a text saying that the installation may take several seconds (without the patch this was not working):</li> </ul><p><a href="https://f.cloud.github.com/assets/1375475/1876706/b32c065a-7916-11e3-8273-0c568f70e284.png" target="_blank"><img src="https://f.cloud.github.com/assets/1375475/1876706/b32c065a-7916-11e3-8273-0c568f70e284.png" alt="screen shot 2014-01-09 at 11 13 40" style="max-width:100%;"></a></p>
Labels	Added: ?