? Failure

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
8 Jan 2014

This PR implements the options to disable the hitcounter and the publish up/publish down feature of com_content as discussed here: https://groups.google.com/forum/#!topic/joomla-dev-cms/LxfiHaOO9Fk

By making it possible to disable the hitcounter, we prevent Joomla from updating the #__content table on each pageview and thus invalidating a potential MySQL query cache.

By making it possible to either reduce the resolution of the timer of the publish up/publish down feature or even disabling that feature altogether, we keep having the exact same query over a longer period of time, allowing MySQL to use its query cache if necessary.

avatar Hackwar Hackwar - open - 8 Jan 2014
avatar Bakual
Bakual - comment - 8 Jan 2014

Can you add a tracker and testing instructions on Joomlacode please?

Will add some comments to code as well

avatar Hackwar Hackwar - change - 9 Jan 2014
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 2 Mar 2014

I can understand why you want this in terms of query performance. But in my opinion this is another example of us having more parameters than we need :/ I personally think we need to be looking to reduce the number of params not increase them

avatar phproberto
phproberto - comment - 2 Mar 2014

I agree with @wilsonge. This also only disables it for articles so it's not totally disabling the hit system.

avatar Hackwar
Hackwar - comment - 2 Mar 2014

The best solution would be to move the hit system out of the component and into a plugin or something. But that is outside of the scope of the 3.x series and since this is a real performance problem on lots of sites right now, I still want to ask to add this. We can fix this in a proper, less parameter expensive way in 4.0, but right now we are stuck with what we got...

Besides, I'm going to be the first one to push for less parameters. That is why this parameter can only be set globally and does not show up in other areas. It might not be consistent either, I haven't checked, but we should be honest to ourselfs: com_content is the bread&butter of every Joomla site. If #content is slow, that is a real issue, since there are sites out there with 100k rows and with table sizes of several gigabytes, while I doubt there is a #weblinks or #__newsfeeds that has more than maybe 2000 entries and weighs more than 2 or 3 MB.

avatar Bakual
Bakual - comment - 2 Mar 2014

The best solution would be to move the hit system out of the component and into a plugin or something. But that is outside of the scope of the 3.x series

You're sure that it's not possible in a BC way? I'd sure would prefer a hacky plugin solution over yet another parameter :smile:
We did some funny things with the contact lookup in com_content. Maybe something along this line could be done here as well?

avatar Hackwar
Hackwar - comment - 3 Mar 2014

This has been in Joomla since 1.5 and as I said, if we wanted to make this right, we would create a statistics interface that we or a third party statistics extension can dock onto and then store the stuff in a central statistics table or something like that. That is outside of the scope of the 3.x series from my perspective and introducing another plugin that is supposed to be removed with 4.0 again, will create more issues than it solves right now.
The parameter can easily be removed again however.

Long story short: It might be possible to implement this in a bc way, but we would introduce new and more issues in the long run imho.

avatar wilsonge
wilsonge - comment - 4 Mar 2014

I wouldn't want to do this in a plugin anyhow. This is what the observer interface was intended to do as well.

avatar Bakual
Bakual - comment - 4 Mar 2014

I wouldn't want to do this in a plugin anyhow. This is what the observer interface was intended to do as well.

The observer is just another plugin system basically. :smile:

avatar brianteeman brianteeman - close - 27 Jul 2014
avatar brianteeman
brianteeman - comment - 27 Jul 2014

Closed as per the comment on the tracker

avatar brianteeman brianteeman - change - 27 Jul 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-07-27 09:24:10
avatar brianteeman brianteeman - close - 27 Jul 2014
avatar Hackwar
Hackwar - comment - 28 Jul 2014

I strongly disagree with simply closing this one. Just because no one tested it, I don't see that this is not relevant. Please open it back up. The issue and PR are still valid.

avatar dbhurley
dbhurley - comment - 28 Jul 2014

I'm reopening. Let's try to get a few tests on this and prove validity.

avatar dbhurley dbhurley - change - 28 Jul 2014
Status Closed New
avatar dbhurley dbhurley - reopen - 28 Jul 2014
avatar dbhurley dbhurley - reopen - 28 Jul 2014
avatar wilsonge
wilsonge - comment - 28 Jul 2014

I can test. But I disgaree with the principle of adding more parameters for this stuff. There just should be a point at which we say you have to deal with this stuff.

avatar rdeutz
rdeutz - comment - 28 Jul 2014

I agree, not more parameters, we have too many already. As far as I know this is only a problem for some sites and not for the majority. I fine with closing this one.

avatar Hackwar
Hackwar - comment - 28 Jul 2014

I agree that we have too many parameters, but I think this is an issue for quite a few sites and as I wrote earlier, it is not something that we can fix nicely within the 3.x series in a BC way. If it were up to me, we would have several batches of parameters only enabled via plugins or something similar and thus reduce the number dramaltically. But that will only be possible with Joomla 4.0. Now, as long as s...stuff like 20 parameters for some obscure links made it into the core, I don't see why we should not add this...

avatar mbabker
mbabker - comment - 28 Jul 2014

As much as I hate the thought of more params, this truthfully feels like
one time to me where it would do more harm than good to not add another one.

On Monday, July 28, 2014, Hannes Papenberg notifications@github.com wrote:

I agree that we have too many parameters, but I think this is an issue for
quite a few sites and as I wrote earlier, it is not something that we can
fix nicely within the 3.x series in a BC way. If it were up to me, we would
have several batches of parameters only enabled via plugins or something
similar and thus reduce the number dramaltically. But that will only be
possible with Joomla 4.0. Now, as long as s...stuff like 20 parameters for
some obscure links made it into the core, I don't see why we should not add
this...


Reply to this email directly or view it on GitHub
#2772 (comment).

avatar losedk
losedk - comment - 28 Jul 2014

If we are going to introduce extra params, it would be obvious to use the recently introduced showon feature:

screenshot at jul 28 22-49-14
screenshot at jul 28 22-48-50

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 Sep 2014
Category SQL
avatar Hackwar Hackwar - close - 23 Dec 2014
avatar Hackwar
Hackwar - comment - 23 Dec 2014

Closing this one, since we will tackle this in a different way in the new MVC

avatar Hackwar Hackwar - change - 23 Dec 2014
Status Pending Closed
Closed_Date 2014-07-27 09:24:10 2014-12-23 16:35:52
avatar Hackwar Hackwar - close - 23 Dec 2014
avatar Hackwar Hackwar - head_ref_deleted - 23 Dec 2014

Add a Comment

Login with GitHub to post a comment