? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jan 2020

The front end component for com_finder aka smart search has an incorrect attribute on the advanced search button. aria-hidden should not be here as it is making a focusable element invisible which is obviously not correct

Using the aria-hidden="true" attribute on an element removes the element and ALL of its child nodes from the accessibility API making it completely inaccessible to screen readers and other assistive technologies. Aria-hidden may be used with extreme caution to hide visibly rendered content from assistive technologies only if the act of hiding this content is intended to improve the experience for users of assistive technologies by removing redundant or extraneous content. If aria-hidden is used to hide visible content from screen readers, the identical or equivalent meaning and functionality must be exposed to assistive technologies.

testing by code review

avatar brianteeman brianteeman - open - 28 Jan 2020
avatar brianteeman brianteeman - change - 28 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2020
Category Front End com_finder
avatar brianteeman brianteeman - change - 28 Jan 2020
The description was changed
avatar brianteeman brianteeman - edited - 28 Jan 2020
avatar Quy Quy - test_item - 28 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 28 Jan 2020

I have tested this item successfully on 71efcb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27692.

avatar Quy
Quy - comment - 28 Jan 2020

I have tested this item successfully on 71efcb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27692.

avatar jwaisner jwaisner - test_item - 28 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jan 2020

I have tested this item successfully on 71efcb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27692.

avatar Quy Quy - change - 28 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27692.

avatar wilsonge wilsonge - change - 28 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-28 22:02:48
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Jan 2020
avatar wilsonge wilsonge - merge - 28 Jan 2020
avatar wilsonge
wilsonge - comment - 28 Jan 2020

Thanks!

avatar brianteeman
brianteeman - comment - 28 Jan 2020

awesome

Add a Comment

Login with GitHub to post a comment