NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jan 2020

We use the library awesomeplete in a few places but the version we have is outdated and has some accessibility bugs.

This PR will update to the latest release 1.1.5

testing

  1. publish the search module
  2. inspect the source of the module and there is NO aria-expanded attribute
  3. apply pr and then npm i
  4. inspect the source of the module and there is an aria-expanded=false attribute
  5. When the popup appears with search results this changes to aria-expanded=true
avatar brianteeman brianteeman - open - 28 Jan 2020
avatar brianteeman brianteeman - change - 28 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2020
Category NPM Change
avatar Quy Quy - test_item - 28 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 28 Jan 2020

I have tested this item successfully on 4746952


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27690.

avatar jwaisner jwaisner - test_item - 28 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jan 2020

I have tested this item successfully on 4746952


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27690.

avatar Quy Quy - change - 28 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27690.

avatar Quy Quy - change - 29 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 29 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-29 20:37:45
Closed_By Quy
Labels Added: NPM Resource Changed ?
avatar Quy Quy - close - 29 Jan 2020
avatar Quy Quy - merge - 29 Jan 2020
avatar brianteeman
brianteeman - comment - 29 Jan 2020

Thx

Add a Comment

Login with GitHub to post a comment