? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
28 Jan 2020

Summary of Changes

Fixes routing not working in com_contact.

Testing Instructions

Create contact category menu item.
View contact item links.

Expected result

SEF links.

Actual result

Non-SEF links.

Documentation Changes Required

IDK.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2020
Category Administration com_contact
avatar SharkyKZ SharkyKZ - open - 28 Jan 2020
avatar SharkyKZ SharkyKZ - change - 28 Jan 2020
Status New Pending
avatar SharkyKZ SharkyKZ - change - 29 Jan 2020
Labels Added: ?
avatar jwaisner jwaisner - test_item - 30 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 30 Jan 2020

I have tested this item successfully on 6d1924b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.

avatar astridx
astridx - comment - 2 Feb 2020

I have tested this successful:

  1. git fetch origin pull/24311/head:ContactFrontendEditJ4

  2. First I made a new installation with standard settings.

  3. I create two contacts

  4. I create a new menu item of the type List Contacts in a Category.

  5. I click menu item List Contacts in a Category and then one item in the list.

  6. I see the url http://localhost/joomla-cms4/index.php/component/contact?view=contact&id=1:test&catid=4

  7. git checkout ContactFrontendEditJ4
    git checkout j4/contact-routing

  8. I click the menu item again and I see http://localhost/joomla-cms4/index.php/list-contacts-in-a-category/1-test

avatar astridx astridx - test_item - 2 Feb 2020 - Tested successfully
avatar astridx
astridx - comment - 2 Feb 2020

I have tested this item successfully on 6d1924b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.

avatar SharkyKZ SharkyKZ - change - 2 Feb 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 2 Feb 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.

avatar rdeutz
rdeutz - comment - 3 Feb 2020

We have to fix the test here, before we merge it

avatar rdeutz rdeutz - change - 3 Feb 2020
Status Ready to Commit Needs Review
avatar astridx
astridx - comment - 3 Feb 2020

What do mean by "
We have to fix the test here, before we merge it"?

avatar astridx
astridx - comment - 3 Feb 2020

Should I test again?
What should I change?

avatar brianteeman
brianteeman - comment - 3 Feb 2020

@astridx Robert is referring to the failing system tests

avatar SharkyKZ
SharkyKZ - comment - 3 Feb 2020

Test failure not related to PR. It's tests for Joomla\CMS\Image that fail sometimes.

avatar rdeutz
rdeutz - comment - 3 Feb 2020

Test failure not related to PR. It's tests for Joomla\CMS\Image that fail sometimes.

yep got that, had started the build quite some time and it had fail at the same step, but now it is good, so my mouse is hovering over the mergen button, stay tuned :-)

avatar rdeutz rdeutz - change - 3 Feb 2020
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-03 22:22:29
Closed_By rdeutz
avatar rdeutz rdeutz - close - 3 Feb 2020
avatar rdeutz rdeutz - merge - 3 Feb 2020

Add a Comment

Login with GitHub to post a comment