User tests: Successful: Unsuccessful:
Fixes routing not working in com_contact.
Create contact category menu item.
View contact item links.
SEF links.
Non-SEF links.
IDK.
Category | ⇒ | Administration com_contact |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
I have tested this successful:
git fetch origin pull/24311/head:ContactFrontendEditJ4
First I made a new installation with standard settings.
I create two contacts
I create a new menu item
of the type List Contacts in a Category.
I click menu item List Contacts in a Category
and then one item
in the list.
I see the url http://localhost/joomla-cms4/index.php/component/contact?view=contact&id=1:test&catid=4
git checkout ContactFrontendEditJ4
git checkout j4/contact-routing
I click the menu item again and I see http://localhost/joomla-cms4/index.php/list-contacts-in-a-category/1-test
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC.
We have to fix the test here, before we merge it
Status | Ready to Commit | ⇒ | Needs Review |
What do mean by "
We have to fix the test here, before we merge it"?
Should I test again?
What should I change?
Test failure not related to PR. It's tests for Joomla\CMS\Image
that fail sometimes.
Test failure not related to PR. It's tests for Joomla\CMS\Image that fail sometimes.
yep got that, had started the build quite some time and it had fail at the same step, but now it is good, so my mouse is hovering over the mergen button, stay tuned :-)
Status | Needs Review | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-03 22:22:29 |
Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 6d1924b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27693.