[#27679] - [4.0] Remove getSortFields from content views
- Fixed in Code Base
- 6 Feb 2020
- Medium
- Build: 4.0-dev
- # 27679
- Diff
- chmst:remove-getsortfields-content
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
List Views have a method getSortFields() - here in com_content.
This Method is not used in the core. The names of the table headers are in the respective tables as language keys.
Testing Instructions
Code Inspect. Testing this can only be playing around with table headers in list views.
Are all texts displayed corretly, does sorting work as before? Also with open search tools?
Expected result
Everything works as before
Note
There are several similiar PRs, hopefully reducin the risk of conflicts
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_workflow |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27679.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27679.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27679.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 22:48:18 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
Seems to me we can remove this entirely from joomla getSortFields is never used
I tested this PR successful
git fetch origin pull/27679/head:remove-getsortfields-content
git checkout remove-getsortfields-content
The sort fields are inserted with an XML file. That is why I first checked if this XML-File is for every component in this PR on his place.
The files
/administrator/components/com_content/forms/filter_articles.xml
/administrator/components/com_content/forms/filter_featured.xml
/administrator/components/com_workflow/forms/filter_stages.xml
/administrator/components/com_workflow/forms/filter_transitions.xml
/administrator/components/com_workflow/forms/filter_workflows.xml
are there.
After that I checked that I could sort articles, categories and featured articles
I had no Workflow items. But the drop down was there and worked.