? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
27 Jan 2020

Summary of Changes

List Views have a method getSortFields(), here multiple used views: com_fields,com_categories.
This Method is not used in the core. The names of the table headers are in the respective tables as language keys.

Testing Instructions

Code Inspect. Testing this can only be playing around with table headers in list views.
Are all texts displayed corretly, does sorting work as before? Also with open search tools?

Expected result

Everything works as before

Note

There are several similiar PRs, hopefully reducin the risk of conflicts

avatar chmst chmst - open - 27 Jan 2020
avatar chmst chmst - change - 27 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2020
Category Administration com_categories com_fields com_languages
avatar astridx
astridx - comment - 6 Feb 2020

I tested this PR successful.

  1. git fetch origin pull/27680/head:remove-getsortfields-general
  2. git checkout remove-getsortfields-general
  3. The sort fields are inserted with an XML file. That is why I first checked if this XML-File is for every component in this PR on his place.
    The files
    /administrator/components/com_language/forms/filter_.xml
    /administrator/components/com_categories/forms/filter_
    .xml
    /administrator/components/com_fields/forms/filter_*.xml
    are there.
  4. After that I checked that I could sort fields, categories and languages.
avatar astridx astridx - test_item - 6 Feb 2020 - Tested successfully
avatar astridx
astridx - comment - 6 Feb 2020

I have tested this item successfully on 237c396


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27680.

avatar jwaisner jwaisner - test_item - 6 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 6 Feb 2020

I have tested this item successfully on 237c396


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27680.

avatar Quy Quy - change - 6 Feb 2020
The description was changed
Status Pending Ready to Commit
avatar Quy Quy - edited - 6 Feb 2020
avatar Quy
Quy - comment - 6 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27680.

avatar chmst
chmst - comment - 6 Feb 2020

@astridx thank you for testing

avatar richard67 richard67 - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 23:46:24
Closed_By richard67
Labels Added: ? ?
avatar richard67 richard67 - close - 6 Feb 2020
avatar richard67 richard67 - merge - 6 Feb 2020
avatar richard67
richard67 - comment - 6 Feb 2020

Thanks.

Add a Comment

Login with GitHub to post a comment