Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#27678] - [4.0] Remove getSortFields from components- part 1

? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
27 Jan 2020

Summary of Changes

List Views have a method getSortFields().
This Method is not used in the core. The names of the table headers are in the respective tables as language keys.
Testing Instructions for com_banners, Com_plugnis, com_csp, com_newsfeeds

Testing Instructions

Code Inspect. Testing this can only be playing around with table headers in list views.
Are all texts displayed corretly, does sorting work as before? Also with open search tools?

Expected result

Everything works as before

avatar chmst chmst - open - 27 Jan 2020
avatar chmst chmst - change - 27 Jan 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2020
Category ⇒ Administration com_banners com_contact com_csp com_newsfeeds com_plugins com_tags
avatar brianteeman
brianteeman - comment - 27 Jan 2020

is it even used in j3?

avatar chmst
chmst - comment - 27 Jan 2020

Yes - Astrid has found a former discussion #5994
So we must be very carfully and I made this PR in full awareness that there can be a discussion ;) . But I think that V4 has been changed and improved in js.

avatar brianteeman
brianteeman - comment - 27 Jan 2020

I think I am as confused now about this code as I was in #5994 ;)

avatar chmst
chmst - comment - 27 Jan 2020

These methods are not used, atleast Icannot find a usage except in com_patchtester for which I will make a PR tomorrow.

avatar astridx
astridx - comment - 6 Feb 2020

I tested this successful.

  1. git fetch origin pull/27678/head:remove-getsortFields-1

  2. git checkout remove-getsortFields-1

  3. The sort fields are inserted with an XML file. That is why I first checked if this XML-File is for every component in this PR on his place.
    The files
    /administrator/components/com_banners/forms/filter_*
    /administrator/components/com_contact/forms/filter_*
    /administrator/components/com_csp/forms/filter_*
    /administrator/components/com_newsfeeds/forms/filter_*
    /administrator/components/com_plugins/forms/filter_*
    /administrator/components/com_tags/forms/filter_*
    are there.

  4. After that I checked that I could sort contacts, banners, plugins, tags, newsfeeds.
    I had no Content Security Policy Reports for sorting. But the drop down was there and worked.

avatar astridx astridx - test_item - 6 Feb 2020 - Tested successfully
avatar astridx
astridx - comment - 6 Feb 2020

I have tested this item ✅ successfully on 93b5a79

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27678.

avatar Quy Quy - test_item - 6 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 6 Feb 2020

I have tested this item ✅ successfully on 93b5a79

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27678.

avatar Quy Quy - change - 6 Feb 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 6 Feb 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27678.

avatar rdeutz rdeutz - change - 6 Feb 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-02-06 22:57:20
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 6 Feb 2020
avatar rdeutz rdeutz - merge - 6 Feb 2020

Add a Comment

Login with GitHub to post a comment