Feeling Lucky
?
[#27677] - [4.0] Remove getsortfields from views of com_users, menus, modules
- Fixed in Code Base
- 6 Feb 2020
- Medium
- Build: 4.0-dev
- # 27677
- Diff
- chmst:remove-getsortfields-users-menus-modules
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
List Views have a method getSortFields().
This Method is not used in the core. The names of the table headers are in the respective tables as language keys.
Testing Instructions
Code Inspect. Testing this can only be playing around with table headers in list views.
Are all texts displayed corretly, does sorting work as before? Also with open search tools?
Expected result
Everything works as before
Note
There are several similiar PRs, hopefully reducin the risk of conflicts
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus com_modules com_users |
astridx
- comment
- 6 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27677.
Quy
- comment
- 6 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27677.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 6 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27677.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 22:50:04 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I tested this successful.
git fetch origin pull/27677/head:remove-getsortfields-users-menus-modules
git checkout remove-getsortfields-users-menus-modules
I have often wondered what I need these methode for. The sort fields are inserted with an XML file. That is why I first checked if this XML-File is for every component in this PR on his place.
The files
/administrator/components/com_menus/forms/filter_*
/administrator/components/com_modules/forms/filter_*
/administrator/components/com_users/forms/filter_*
are there.
After that I checked that I could sort
users,menusitems andadmin/site modules.