@brianteeman I'd be happy if you could find time and review language strings, and - what is more important - accessibility of the new fields, if necessary.

@brianteeman P.S.: I'd also be happy if you could give feeback regarding point 2 in the "To be done" section of the description of this PR, if that alert div shall always be there and only visibility is changed with js like it is now, or if maybe the alert class also should be changed from warning to something else if that div is hidden, or how that is normally handled. Thanks in advance.

Update: Removed the "To be done" section because I have the feeling it might discourage people from testing. You'll see anyway if this PR does it in a good or a bad way when looking at the code changes.

@Fedik As you are very good in Joomla JS: Do you know if we already have something to make bytes nice, i.e. not show 16777216 bytes but 16 MB, or GB or whatever we have? I know it's not a big thing to write it bout would be pity to have duplicate functionality at several places.

Do you know if we already have something to make bytes nice, i.e. not show 16777216 bytes but 16 MB, or GB or whatever we have?

I did not seen such in Joomla code

@richard67 are you looking for this

Other than comments about the strings and size it all seems to work fine

@richard67 are you looking for this

joomla-cms/libraries/src/Filesystem/FilesystemHelper.php

Lines 360 to 374 in 64b9025

	* Creates the rounded size of the size with the appropriate unit
	*
	* @param float $max_size The maximum size which is allowed for the uploads
	*
	* @return string String with the size and the appropriate unit
	*
	* @since 3.4
	*/
	private static function parseSizeUnit($max_size)
	{
	$base = log($max_size) / log(1024);
	$suffixes = array('', 'k', 'M', 'G', 'T');
	return round(pow(1024, $base - floor($base)), 0) . $suffixes[floor($base)];
	}

@brianteeman For same functionality but available in javascript so I can use it here: https://github.com/joomla/joomla-cms/pull/27570/files#diff-b155936a54bbb6b34c31eb456d23a45cR48. The actual file size is determined in javascript, so I can't prepare formatted output for it in PHP like I can with the maximum allowed file size.

sorry missed the js part of the question - something like this should do it

this.files[0].size/1024/1024 + "MB"

PS fileSizeAct - what does the Act mean/represent?

@brianteeman If I want to hard-code it to MB then yes, this works. But what if GB would be more suitable?

@brianteeman "act" stands for "actual", i.e. size of actually selected file, on opposite to "max", which stands for the maximum allowed.

@brianteeman Since the PHP limits are in almost all cases given in MB, do you think it's ok to hard-code the displayed size of the actually selected file always in MB, i.e. use your code above? If you think it's ok I'll update my PR to do so.

@brianteeman If I want to hard-code it to MB then yes, this works. But what if GB would be more suitable?

hardly likely that someone would try to load a file that large via a web browser. And if they really did try to then I am sure they would understand why 5000MB is too big

@brianteeman "act" stands for "actual", i.e. size of actually selected file, on opposite to "max", which stands for the maximum allowed.

Doesnt make sense to me - what is wrong with simply saying fileSize

what is wrong with simply saying fileSize

@brianteeman Nothing wrong with that, I just thought fileSizeAct would be more precise. But if you think it is confusing I can change that. Readability of code is an important thing.

Other question: If I implement all changes suggested by you, will you then test this PR and mark the result in the issue tracker? ;-)

Implemented all changes suggested by @brianteeman . Thanks for review.

To him and all other readers: Please test (if you have npm).

Updated also testing instructions (text and screenshots).

@wilsonge Could you review again? I've made a few changes, see last commit message. Thanks in advance.

I have tested this item ✅ successfully on 975fb9b

I have tested this item ✅ successfully on 975fb9b

LGTM

@brianteeman Thanks a lot. If you have time and mood, could you also test my similar PR for the extensions installer, PR #27665 ?

already done

I have tested this item ✅ successfully on 975fb9b

RTC

Thanks for testing.

Thanks.