? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
19 Jan 2020

Pull Request for Issue #27329 .

Summary of Changes

Upgrade php-stemmer from version 1.2 to 2.0, refactoring stemmer class to use stemmer factory.

Testing Instructions

Use smart search with different languages and content.

Expected result

Nothing changes.

Actual result

Everything still works.

avatar HLeithner HLeithner - open - 19 Jan 2020
avatar HLeithner HLeithner - change - 19 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2020
Category Administration com_finder External Library Composer Change
avatar brianteeman
brianteeman - comment - 19 Jan 2020

Did you mean to delete all those files?

avatar HLeithner
HLeithner - comment - 19 Jan 2020

Yes they are not longer needed.

avatar brianteeman
brianteeman - comment - 19 Jan 2020

thanks for the clarification

avatar jwaisner jwaisner - test_item - 20 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 20 Jan 2020

I have tested this item successfully on a2e5c36

Looks good. Cleared index and re-indexed successfully. Added multiple articles and categories and re-indexed. No errors and data indexed correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27568.

avatar HLeithner
HLeithner - comment - 20 Jan 2020

Thx for the text but I will change the exception later but shouldn't effect your test.
@mbabker would assume * as default language betyer instead throwing an exception?

avatar infograf768 infograf768 - change - 21 Jan 2020
Title
Upgrade php-stemmer 2.0
[4.0] Upgrade php-stemmer 2.0
avatar infograf768 infograf768 - edited - 21 Jan 2020
avatar HLeithner HLeithner - change - 21 Jan 2020
Labels Added: ? ?
fbe9a24 22 Jan 2020 avatar HLeithner cs
avatar wilsonge wilsonge - change - 24 Jan 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-24 11:29:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Jan 2020
avatar wilsonge wilsonge - merge - 24 Jan 2020
avatar wilsonge
wilsonge - comment - 24 Jan 2020

Thanks!

Add a Comment

Login with GitHub to post a comment