? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
17 Jan 2020

Summary of Changes

Remove title tooltip that has redundant info overlapping tooltip.

Testing Instructions

Install Multilingual Sample Data.
Go to Articles list.
Under Association column, hover over a badge.
See tooltip overlapping tooltip.

Do the same for Categories, Contacts, News Feeds, and Menus.

Actual result

tooltip

avatar Quy Quy - open - 17 Jan 2020
avatar Quy Quy - change - 17 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2020
Category Administration com_categories com_contact com_content com_menus com_newsfeeds
avatar SharkyKZ SharkyKZ - test_item - 17 Jan 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 17 Jan 2020

I have tested this item successfully on 5764702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27557.

avatar infograf768 infograf768 - test_item - 18 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 18 Jan 2020

I have tested this item successfully on 5764702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27557.

avatar infograf768
infograf768 - comment - 18 Jan 2020

Thanks. I tested it ok.
We have the same issue for com_associations:
I solved it by

diff --git a/administrator/components/com_associations/Helper/AssociationsHelper.php b/administrator/components/com_associations/Helper/AssociationsHelper.php
index 3dc84f2..651a1b4 100644
--- a/administrator/components/com_associations/Helper/AssociationsHelper.php
+++ b/administrator/components/com_associations/Helper/AssociationsHelper.php
@@ -338,5 +338,5 @@
 			$classes = 'badge ' . $labelClass;
 
-			$items[$langCode]['link'] = '<a href="' . $url . '" title="' . $language->title . '" class="' . $classes . '">' . $text . '</a>'
+			$items[$langCode]['link'] = '<a href="' . $url . '" class="' . $classes . '">' . $text . '</a>'
 				. '<div role="tooltip">' . $tooltip . '</div>';
 		}

Shall you add it in this PR or make a new PR?

avatar Quy Quy - change - 18 Jan 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2020
Category Administration com_categories com_contact com_content com_menus com_newsfeeds Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds
avatar infograf768
infograf768 - comment - 19 Jan 2020

@SharkyKZ
can you test again, this time for com_associations?

avatar SharkyKZ SharkyKZ - test_item - 19 Jan 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 19 Jan 2020

I have tested this item successfully on 40d33f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27557.

avatar Quy Quy - change - 19 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27557.

avatar Quy
Quy - comment - 19 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27557.

avatar HLeithner HLeithner - change - 20 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-20 14:47:55
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 20 Jan 2020
avatar HLeithner HLeithner - merge - 20 Jan 2020
avatar HLeithner
HLeithner - comment - 20 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment