?
avatar ciar4n
ciar4n
17 Jan 2020

The CSS for the control-group field (most Joomla fields) uses an old floating hack to align the label with the field. I presume this is something that predates even J3. Basically it floats the label to take it out of the flow of the page and then places a left margin on the field to give it a fixed inset width. I propose moving them to use flex instead. It is a typical scenario flex is used designed for.

  • Less CSS required
  • Flex naturally supports RTL so no RTL CSS required.
  • Media queries look at the width of the viewport and are the only way to change the orientation of the current control-group fields. Flex would allow us to change the orientation of the field depending on the space available to it. A much more versatile and safer way to approach responsive fields especially.

It is a change that would touch a large part of the Joomla UI so I am reluctant in making such a change without bringing it up as an issue first. Maybe there is a reason this wasn't done before that I am unaware of?

avatar ciar4n ciar4n - open - 17 Jan 2020
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Jan 2020
avatar ciar4n ciar4n - change - 17 Jan 2020
The description was changed
avatar ciar4n ciar4n - edited - 17 Jan 2020
avatar SharkyKZ
SharkyKZ - comment - 24 Jan 2020

That would be great. Does this require much change in HTML markup? Or are changes mostly limited to CSS?

avatar Fedik
Fedik - comment - 24 Jan 2020

that would be cool to fix ?

avatar ciar4n
ciar4n - comment - 26 Jan 2020

Does this require much change in HTML markup? Or are changes mostly limited to CSS?

No change required in the HTML. Change would be CSS only.

avatar ciar4n
ciar4n - comment - 27 Jan 2020

PR created... #27684

avatar ciar4n ciar4n - change - 27 Jan 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-01-27 21:51:07
Closed_By ciar4n
avatar ciar4n ciar4n - close - 27 Jan 2020

Add a Comment

Login with GitHub to post a comment