Feeling Lucky
?
?
[#27556] - [4.0] Fix invalid argument for foreach
- Fixed in Code Base
- 21 Jan 2020
- Medium
- Build: 4.0-dev
- # 27556
- Diff
- Quy:invalid-argument
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fix Invalid argument supplied for foreach() in \libraries\src\Form\FormField.php on line 1134 by checking that it is an array.
Testing Instructions
- Create a text field.
- Create a subfield field.
- Edit an article (leave subfield field empty).
- Save the article.
- Check PHP error log.
- Apply PR.
- Check PHP error log for no errors.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Fedik
- comment
- 18 Jan 2020
It may be both, object or array
maybe try !is_scalar($value)
for subform it may enough to check the value exists:
if ($this->multiple && $value)
| Labels |
Added:
?
|
||
Fedik
- comment
- 20 Jan 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27556.
jwaisner
- comment
- 21 Jan 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27556.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 21 Jan 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27556.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-21 11:49:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 21 Jan 2020
Thanks!
Looks like
$valueis normally an object, not an array.