NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
12 Jan 2020

Pull Request for Issue #27491

Summary of Changes

remove hidden class when Unassigned Modules or Unpublished Modules are set to Show

Testing Instructions

See #27491

After patch

The rows are no more empty and show the Display and Published badges correctly.

avatar infograf768 infograf768 - open - 12 Jan 2020
avatar infograf768 infograf768 - change - 12 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2020
Category JavaScript Repository NPM Change
avatar Quy
Quy - comment - 12 Jan 2020

It works the first time, but if you hide it again, you get a blank row.

27492

avatar jwaisner
jwaisner - comment - 12 Jan 2020

I get the same result. I even tested with the "unassigned module" toggle and it did the same thing. Created empty rows if I toggled either more than once.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492.

avatar infograf768 infograf768 - change - 13 Jan 2020
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 13 Jan 2020

@Quy @jwaisner
Should be OK now. Please test again.

avatar jwaisner jwaisner - test_item - 13 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 13 Jan 2020

I have tested this item successfully on 114971d

Both toggle functions work as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492.

avatar Quy Quy - test_item - 13 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 13 Jan 2020

I have tested this item successfully on 55ead68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492.

avatar Quy Quy - change - 13 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27492.

avatar Quy
Quy - comment - 13 Jan 2020

There is vertical spacing issue when hiding unassigned modules, but can be done in a different PR.

27492a

avatar infograf768 infograf768 - change - 13 Jan 2020
Labels Added: ?
avatar HLeithner
HLeithner - comment - 13 Jan 2020

There is vertical spacing issue when hiding unassigned modules, but can be done in a different PR.

27492a

Is this a regression? If you then you should remove the RTC tag

avatar infograf768
infograf768 - comment - 13 Jan 2020

Will look at this tomorrow, not sure it is regression as the only changes concern class remove

avatar brianteeman
brianteeman - comment - 13 Jan 2020

I can not replicate @Quy findings - all looks good to me

avatar infograf768
infograf768 - comment - 14 Jan 2020

I confirm no issue here.
@HLeithner
Please merge

avatar HLeithner HLeithner - close - 14 Jan 2020
avatar HLeithner HLeithner - merge - 14 Jan 2020
avatar HLeithner HLeithner - change - 14 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-14 08:07:02
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 14 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment