? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
12 Jan 2020

Pull Request for Issue #27214.

Summary of Changes

php 7.4 compatibility

Testing Instructions

If you compare two versions of an article you will get the error
Deprecated: array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead in \joomla-cms\administrator\components\com_contenthistory\Model\CompareModel.php on line 104

Expected result

no deprecated messages in log when php 7.4

Actual result

deprecated messages in log

avatar alikon alikon - open - 12 Jan 2020
avatar alikon alikon - change - 12 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jan 2020
Category Administration com_content com_contenthistory
avatar brianteeman
brianteeman - comment - 12 Jan 2020

fixes the issue with compare two versions
now I can see an issue when you preview a version

Deprecated: array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead in administrator\components\com_contenthistory\Model\PreviewModel.php on line 96


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27493.
avatar alikon alikon - change - 12 Jan 2020
Labels Added: ?
avatar alikon
alikon - comment - 12 Jan 2020

should be fixed now

avatar brianteeman brianteeman - test_item - 12 Jan 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Jan 2020

I have tested this item successfully on d9c77a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27493.

avatar richard67 richard67 - test_item - 12 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 12 Jan 2020

I have tested this item successfully on d9c77a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27493.

avatar richard67 richard67 - change - 12 Jan 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 12 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27493.

avatar Quy Quy - change - 12 Jan 2020
Labels Added: ?
avatar wilsonge wilsonge - change - 16 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-16 11:55:27
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 16 Jan 2020

Thanks!

avatar laoneo
laoneo - comment - 5 Jun 2020

Backported it to staging in #29430.

Add a Comment

Login with GitHub to post a comment