NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Jan 2020

Due to a change between tinyMCE 4 and 5 although you could see and use the text colour and text background colour buttons in the toolbar you could not see them in the plugin so you lost the ability to add/remove those buttons to different sets

requires npm -i

Go to the plugin
check that Set 0 shows the two buttons
check that the collection of available buttons shows the two buttons

PS That took way too long to work out where the problem was :(

Pull Request for Issue #26333

avatar brianteeman brianteeman - open - 10 Jan 2020
avatar brianteeman brianteeman - change - 10 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2020
Category JavaScript Repository NPM Change Front End Plugins
avatar brianteeman
brianteeman - comment - 10 Jan 2020

Any help on fixing hound would be appreciated - it all looks fine to me

avatar richard67
richard67 - comment - 10 Jan 2020

Just remove the single quotes around the word “forecolor”

avatar brianteeman brianteeman - change - 10 Jan 2020
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 10 Jan 2020

Thanks guys - I misread the message

avatar jwaisner jwaisner - test_item - 10 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 10 Jan 2020

I have tested this item successfully on b7b4c4b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27465.

avatar Quy Quy - test_item - 10 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 10 Jan 2020

I have tested this item successfully on b7b4c4b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27465.

avatar Quy Quy - change - 10 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27465.

avatar wilsonge wilsonge - change - 11 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-11 00:18:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 11 Jan 2020

Thanks!

avatar brianteeman
brianteeman - comment - 11 Jan 2020

thanks

Add a Comment

Login with GitHub to post a comment