? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Jan 2020

(there may be a better way to do this but I couldnt find it)

Before

image

After

image

testing

don't forget npm i

avatar brianteeman brianteeman - open - 10 Jan 2020
avatar brianteeman brianteeman - change - 10 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2020
Category Repository NPM Change
avatar jwaisner jwaisner - test_item - 10 Jan 2020 - Tested unsuccessfully
avatar jwaisner
jwaisner - comment - 10 Jan 2020

I have tested this item ? unsuccessfully on 1f57e61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466.

avatar jwaisner
jwaisner - comment - 10 Jan 2020

After patching and completing npm i, the alignment did not change as the expected result. I tested this in Firefox and Chrome.
27466

avatar brianteeman
brianteeman - comment - 10 Jan 2020

Did you run npm i to rebuild the scripts?

avatar Quy Quy - test_item - 10 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 10 Jan 2020

I have tested this item successfully on 1f57e61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466.

avatar Quy
Quy - comment - 10 Jan 2020

@jwaisner Try clearing browser's cache.

avatar jwaisner jwaisner - test_item - 10 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 10 Jan 2020

I have tested this item successfully on 1f57e61

@brianteeman yes

@Quy just tried that and it didnt work

End result, I did a complete reset of my environment and it works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466.

avatar Quy Quy - change - 10 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27466.

avatar Fedik
Fedik - comment - 10 Jan 2020

hold on, this is wrong fix :)

avatar Fedik
Fedik - comment - 10 Jan 2020

no, sorry, ignore my previous comment

avatar Quy Quy - change - 10 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-10 19:47:05
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 10 Jan 2020
avatar Quy Quy - merge - 10 Jan 2020
avatar brianteeman
brianteeman - comment - 10 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment