User tests: Successful: Unsuccessful:
Pull Request for Issue #27409 (comment)
As ml-2
has been corrected for RTL in #27409 , we should not use it anymore in atum layouts/chromes/well as mr-2 was already overriden for rtl
{EDIT] see below #27444 (comment)
Install Persian (fa-IR) language and set admin language to Persian.
Display Control Panel Look at the quickicons
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Labels |
Added:
?
|
@Quy
In fact we do not need to add card-reader
at all as it already present in well.php in the <div>
For the content dashboard, the code is in the mod_submenu tmpl
Therefore I just deleted the useless mr2 indeed and used your multiple echo.
Modifying PR title now.
Title |
|
I have tested this item
@infograf768 I don't really see a difference in the before and after screenshots, except maybe that the "+" bar is a bit wider compared to the rest of the button in the after screenshot, but this might be caused by lower screen width. So what should I check when testing?
Ahhh, how could I miss that? Think I need glasses ;-)
I have tested this item
Thanks god the logout button is easy to find so I can quickly logout and return to my default language. Not easy to test in Persian when not being able to read Persian.
I have tested this item
Thanks god the logout button is easy to find so I can quickly logout and return to my default language. Not easy to test in Persian when not being able to read Persian.
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-27 02:06:15 |
Closed_By | ⇒ | Quy |
Thanks god the logout button is easy to find so I can quickly logout and return to my default language. Not easy to test in Persian when not being able to read Persian.
This is my trick when I have to test RTL:
I use multiple windows, one of them being the Installed Languages.
Then I display in another window (in en-GB ) the page where I have to test a patch or use dev tools to find out where an error comes from.
Then I switch languages in the other window, back and forth.
We may not need
mr-2
. See the markup between the following.Home Dashboard:
Content Dashboard:
Change line 71 to fix the issue and add class
card-header
to be consistent with other dashboards.