? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 Jan 2020

Pull Request for Issue #27409 (comment)

Summary of Changes

As ml-2 has been corrected for RTL in #27409 , we should not use it anymore in atum layouts/chromes/well as mr-2 was already overriden for rtl

{EDIT] see below #27444 (comment)

Testing Instructions

Install Persian (fa-IR) language and set admin language to Persian.
Display Control Panel Look at the quickicons

Before patch

Screen Shot 2020-01-09 at 10 30 44

After patch

Screen Shot 2020-01-09 at 10 34 02

@brianteeman

avatar infograf768 infograf768 - open - 9 Jan 2020
avatar infograf768 infograf768 - change - 9 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jan 2020
Category Administration Templates (admin)
avatar infograf768 infograf768 - change - 10 Jan 2020
Labels Added: ?
avatar Quy
Quy - comment - 10 Jan 2020

We may not need mr-2. See the markup between the following.

Home Dashboard:

<h2><span class="fa fa-sync mr-2" aria-hidden="true"></span>Update Checks</h2>

Content Dashboard:

<h2 class="card-header">
        <span class="fa fa-cog" aria-hidden="true"></span>				Content Settings			</h2>

Change line 71 to fix the issue and add class card-header to be consistent with other dashboards.

						<h2<?php echo $headerClass; ?>>
							<?php echo $headerIcon; ?>
							<?php echo htmlspecialchars($module->title); ?>
						</h2>
d18283b 16 Jan 2020 avatar infograf768 oops
avatar infograf768
infograf768 - comment - 16 Jan 2020

@Quy
In fact we do not need to add card-reader at all as it already present in well.php in the <div>
For the content dashboard, the code is in the mod_submenu tmpl

Therefore I just deleted the useless mr2 indeed and used your multiple echo.
Modifying PR title now.

avatar infograf768 infograf768 - change - 16 Jan 2020
Title
[4.0] RTL using mr2 in well chrome
[4.0] RTL no need for ml2 or mr2 in well.php
avatar infograf768 infograf768 - edited - 16 Jan 2020
avatar infograf768 infograf768 - change - 16 Jan 2020
The description was changed
avatar infograf768 infograf768 - edited - 16 Jan 2020
avatar Quy Quy - test_item - 16 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 16 Jan 2020

I have tested this item successfully on 02229ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27444.

avatar richard67
richard67 - comment - 26 Jan 2020

@infograf768 I don't really see a difference in the before and after screenshots, except maybe that the "+" bar is a bit wider compared to the rest of the button in the after screenshot, but this might be caused by lower screen width. So what should I check when testing?

avatar brianteeman
brianteeman - comment - 26 Jan 2020

before the patch the icon is touching the word in the title in the top right
image

avatar richard67
richard67 - comment - 26 Jan 2020

Ahhh, how could I miss that? Think I need glasses ;-)

avatar richard67 richard67 - test_item - 26 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 26 Jan 2020

I have tested this item successfully on 7ab8e09

Thanks god the logout button is easy to find so I can quickly logout and return to my default language. Not easy to test in Persian when not being able to read Persian.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27444.

avatar richard67
richard67 - comment - 26 Jan 2020

I have tested this item successfully on 7ab8e09

Thanks god the logout button is easy to find so I can quickly logout and return to my default language. Not easy to test in Persian when not being able to read Persian.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27444.

avatar richard67 richard67 - change - 26 Jan 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27444.

avatar richard67
richard67 - comment - 26 Jan 2020

@Quy 's test was still valid because the only 2 commits since then were clean branch update to base branch. Therefore RTC now with 2 good tests.

avatar Quy Quy - change - 27 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 27 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-27 02:06:15
Closed_By Quy
avatar Quy Quy - close - 27 Jan 2020
avatar Quy Quy - merge - 27 Jan 2020
avatar infograf768
infograf768 - comment - 27 Jan 2020

@richard67

Thanks god the logout button is easy to find so I can quickly logout and return to my default language. Not easy to test in Persian when not being able to read Persian.

This is my trick when I have to test RTL:
I use multiple windows, one of them being the Installed Languages.
Then I display in another window (in en-GB ) the page where I have to test a patch or use dev tools to find out where an error comes from.
Then I switch languages in the other window, back and forth.

Add a Comment

Login with GitHub to post a comment