[#27443] - [4.0] Searchtools mobile display
- Fixed in Code Base
- 10 Jan 2020
- Medium
- Build: 4.0-dev
- # 27443
- Diff
- infograf768:4.0_searchtools_mobile
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Follow-up on #27416
Summary of Changes
Take off from _toolbar.scss .js-stools-container-selector which interfere with searchtools.css
Correct margins in mobile view as the situation is different when we have .js-stools-container-selector (1 field) or .js-stools-container-selector-first (2 fields).
Testing Instructions
Install multiple languages including Persian (fa-IR)
Display in Mobile view the Installed language manager and also the Menu Items manager.
These contains fields separated from the main searchtools (site/admin for Installed languages and site/admin // menu for menu items.
Patch and use npm
Before patch
LTR
RTL
After patch
LTR
RTL
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
It works but it needs cleaning up to prevent repetition
| Labels |
Added:
?
|
||
Alas I had already merged 8b25305
Therefore your proposals were hard to find out.
Anyway I modified with most of your suggestions.
Except some that kill the alignment in LTR when we have 2 fields (menu items manager) for the second field. I had there to keep repeating margin-right: 0;
Please look again and test. If you propose some more changes, please test them before, following my instructions.
It looks like you got them all.
On a side note, there is a couple of ways of improving this...
-
mobile first - only apply the margins to desktops
media-breakpoint-up(sm)rather than applying margins to all and then taking it away on small screens. -
Create a unique class for all toolbar fields and only define changes once.
Not sure at all what you mean as xs may need different margins than sm
On a single column layout there is no reason why they should. The frontend template CSS is mobile first, which is why I suggested it here.
Then please make patch.
I have tested this item
This works. Suggestions can be applied template wide in a separate pr (if required).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27443.
@ciar4n
thanks for testing
BTW, I can demonstrate easily why we will have different margin-right when we are in LTR and 2 fields are concerned. xs needs margin-right: .5rem while sm needs margin-right: 0;
Can send you an animated gif if you desire.
@brianteeman
Please mark your test so that we merge this.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27443.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27443.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-10 20:25:01 |
| Closed_By | ⇒ | HLeithner |
Thanks
quickcheck - looks great
will test properly later today