Feeling Lucky
?
?
[#27445] - [4.0] Module Assignment [a11y]
- Fixed in Code Base
- 11 Jan 2020
- Medium
- Build: 4.0-dev
- # 27445
- Diff
- brianteeman:search_module
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
When you assign a module to a menu item there is a select for On All Pages, Selected etc
If you are on the either of the two "selected" options you will see a search box and a tree.
-
The search input does not have a label - for a11y it must have one - this PR adds aria-label attribute to resolve that
-
The search input has tabindex-1 which means that it is not part of the navigation tree and you can never tab into the input to perform a search - this PR removes the tabindex so you can now tab into the search input
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus com_modules |
| Labels |
Added:
?
|
||
jwaisner
- comment
- 9 Jan 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27445.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 9 Jan 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27445.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-11 13:36:00 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 11 Jan 2020
Thanks!
brianteeman
- comment
- 11 Jan 2020
w00t
I have tested this item✅ successfully on 3506d83
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27445.