NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
6 Jan 2020

Fixes #27401.

Summary of Changes

Makes password view toggle markup consistent.
Fixes toggler in frontend login form.
Corrects selector in JS.

Testing Instructions

Test that password view toggle works in admin login, frontend login (module) and registration forms. Check that Show/Hide text is toggled correctly (using screen reader or using browser dev tools).

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 6 Jan 2020
avatar SharkyKZ SharkyKZ - change - 6 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2020
Category JavaScript Repository NPM Change Layout Modules Front End
avatar brianteeman
brianteeman - comment - 6 Jan 2020

Thank you.

avatar brianteeman brianteeman - test_item - 6 Jan 2020 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 6 Jan 2020

I have tested this item ? unsuccessfully on c89ea1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412.

avatar brianteeman
brianteeman - comment - 6 Jan 2020

Almost but not quite

pass

avatar SharkyKZ SharkyKZ - change - 6 Jan 2020
Labels Added: NPM Resource Changed ?
avatar SharkyKZ
SharkyKZ - comment - 6 Jan 2020

Test again please.

avatar brianteeman brianteeman - test_item - 6 Jan 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 6 Jan 2020

I have tested this item successfully on f1c37d7

that's it !;)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412.

avatar Quy Quy - test_item - 6 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 6 Jan 2020

I have tested this item successfully on f1c37d7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412.

avatar Quy Quy - change - 6 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27412.

avatar HLeithner HLeithner - change - 6 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-06 23:10:36
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 6 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment