? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
6 Jan 2020

Closes #27147.

Summary of Changes

Disable Password Reset Required flag when after users complete password reset.

Testing Instructions

Create a user. Set "Require Password Reset" to Yes.
In frontend, use password reset form for that user.
Reset the password.
Login.

Expected result

Not required to reset password again.

Actual result

Required to reset password again.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 6 Jan 2020
avatar SharkyKZ SharkyKZ - change - 6 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jan 2020
Category Front End com_users
avatar mbabker
mbabker - comment - 6 Jan 2020

This should not be needed in component level MVC. There is logic in the User class to take care of clearing the flag if the class is actually used correctly.

avatar SharkyKZ SharkyKZ - change - 6 Jan 2020
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 6 Jan 2020

@mbabker Thanks for the tip. I hope this is what you meant.

avatar mbabker
mbabker - comment - 6 Jan 2020

Looks right just going from memory.

avatar vbv2312
vbv2312 - comment - 7 Jan 2020

can i as a beginner work on this issue to contrive a patch ??please can anyone guide me i am new to open source


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27413.

avatar SharkyKZ
SharkyKZ - comment - 7 Jan 2020

@vbv2312 this is already a patch for issue #27147. No need for another patch for the same issue, unless you have a better/nicer solution. Other than that, yes, you can work on any issue you want and don't need to ask for permission. See this documentation page for information about contributing https://docs.joomla.org/Portal:Joomla!_Code_Contributors.

avatar vbv2312
vbv2312 - comment - 8 Jan 2020

Can you please suggest some good first bugs for me I am a beginner and want to contribute . Thanks

avatar alikon
alikon - comment - 8 Jan 2020

@vbv2312 you could simply test this one for start https://docs.joomla.org/Testing_Joomla!_patches

avatar vbv2312
vbv2312 - comment - 8 Jan 2020

@vbv2312 you could simply test this one for start https://docs.joomla.org/Testing_Joomla!_patches

okk can you please lay out some more tasks so that i can brush up my contribution to open source

avatar alikon
alikon - comment - 8 Jan 2020

Have you tested this PR ?
if yes, you should "Record your test results" as reported here https://docs.joomla.org/Testing_Joomla!_patches

avatar jwaisner jwaisner - test_item - 8 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 8 Jan 2020

I have tested this item successfully on 1c2d32e

Works great. Flag is disabled after user resets password.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27413.

avatar Quy Quy - test_item - 9 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 9 Jan 2020

I have tested this item successfully on 1c2d32e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27413.

avatar Quy Quy - change - 9 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27413.

avatar HLeithner HLeithner - change - 9 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-09 11:52:42
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 9 Jan 2020
avatar HLeithner HLeithner - merge - 9 Jan 2020
avatar HLeithner
HLeithner - comment - 9 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment