? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
3 Jan 2020

Pull Request for Issue #27222

Summary of Changes

  • Add title, aria-label etc. like requested in #27222
  • Add new protected $list to avoid redundant code.
  • Remove senseless Next/Previous if not linked (on first and last page).

Comment

- Please check if the aria-label should be changed! I couldn't find any "nice" language strings.

Current HTML

<ul>
 <li>
  <a class="hasTooltip" href="/path/8-beginners" title="Beginners" aria-label="Previous: Beginners (Page 1 of 7)" rel="prev">
  <span class="icon-chevron-left" aria-hidden="true"></span> <span aria-hidden="true">Prev</span>
  </a>
 </li>
 <li>
  <a class="hasTooltip" href="/path/8-beginners?start=2" title="alias 1" aria-label="Next: alias 1 (Page 3 of 7)" rel="next">
   <span aria-hidden="true">Next</span> <span class="icon-chevron-right" aria-hidden="true"></span>
  </a>
 </li>
</ul>

Testing Instructions

  • Create a new article that contains several page breaks.
    Mix page breaks with and without title, with and without alias and page breaks without title AND alias.

  • Make sure that the plugin "Content - Page Break" is enabled and presentation style is set to "Pages".
    Test also with setting "Show All" on and off if page numbering still correct.

  • Open article in front-end with "Protostar" template.

  • Check page break navigation and have also a look on the created HTML.
    03-01-_2020_22-01-09

  • Has these ugly tooltips now?

  • aria-labels; correct numbering?

  • and so on

Expected result

  • No B\C break with existing overrides of toc.php ($list versus $this->list).
  • No grave changes concerning look&feel etc.
avatar ReLater ReLater - open - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2020
Category Front End Plugins
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar brianteeman
brianteeman - comment - 3 Jan 2020
Notice: Undefined variable: list in C:\htdocs\cms\plugins\content\pagebreak\pagebreak.php on line 287

Notice: Trying to access array offset on value of type null in C:\htdocs\cms\plugins\content\pagebreak\pagebreak.php on line 287

Notice: Trying to get property 'liClass' of non-object in C:\htdocs\cms\plugins\content\pagebreak\pagebreak.php on line 287
Database Type mysql
Database Version 8.0.18
Database Collation utf8_general_ci
Database Connection Collation utf8mb4_0900_ai_ci
PHP Version 7.4.0
avatar brianteeman brianteeman - test_item - 3 Jan 2020 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 3 Jan 2020

I have tested this item ? unsuccessfully on 62658f0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27398.

avatar ReLater ReLater - change - 3 Jan 2020
Labels Added: ?
avatar brianteeman brianteeman - test_item - 3 Jan 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 Jan 2020

I have tested this item successfully on e3f840e

LGTM


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27398.

avatar alikon alikon - test_item - 4 Jan 2020 - Tested successfully
avatar alikon
alikon - comment - 4 Jan 2020

I have tested this item successfully on e3f840e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27398.

avatar alikon alikon - change - 4 Jan 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 4 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27398.

avatar rdeutz rdeutz - change - 4 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-04 14:16:35
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 4 Jan 2020
avatar rdeutz rdeutz - merge - 4 Jan 2020

Add a Comment

Login with GitHub to post a comment