?
avatar ReLater
ReLater
3 Jan 2020

Steps to reproduce the issue

According to pr review #27398 (review) by @brianteeman the button texts "Next/Prev" of page navigation should not have the attributes aria-hidden. We removed these attributes in pr 27398 in pagebreak plugin.

<li class="next">
 <a class="hasTooltip" title="" aria-label="Next article: Getting Help" href="/path/getting-help" rel="next" data-original-title="Getting Help">
  <span aria-hidden="true">Next</span>
  <span class="icon-chevron-right" aria-hidden="true"></span>
 </a>
</li>

https://github.com/joomla/joomla-cms/blob/staging/plugins/content/pagenavigation/tmpl/default.php#L22

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar ReLater ReLater - open - 3 Jan 2020
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar ReLater ReLater - change - 3 Jan 2020
The description was changed
avatar ReLater ReLater - edited - 3 Jan 2020
avatar brianteeman
brianteeman - comment - 3 Jan 2020

the original pr was #17508

maybe i am wrong

avatar ReLater
ReLater - comment - 4 Jan 2020

Pinging @zwiastunsw

avatar SharkyKZ
SharkyKZ - comment - 4 Jan 2020

#17508 added a different description for screen readers via aria-label attribute. Original description was made invisible to screen readers to avoid duplicated description.

avatar ReLater
ReLater - comment - 4 Jan 2020

to avoid duplicated description.

Yes, but that's nearly the same in #27398

We have an aria-label like aria-label="Next: Title of next page (Page 3 of 7)" and a visible button Next (no aria-hidden=true). Thus a screenreader provides nearly duplicated informations with current state of code.

I don't know...

avatar ReLater ReLater - change - 15 Jan 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-01-15 19:11:49
Closed_By ReLater
avatar ReLater ReLater - close - 15 Jan 2020

Add a Comment

Login with GitHub to post a comment