? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Jan 2020

image

Issue

Form elements must have labels (label)

Target application

Multilingual Associations: Edit Associations (Articles > Articles) - 4.0 Test Site - Administration

Element path

#jform_itemlanguage

Snippet

<select id="jform_itemlanguage" name="jform[itemlanguage]" class="custom-select">

avatar brianteeman brianteeman - open - 3 Jan 2020
avatar brianteeman brianteeman - change - 3 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2020
Category Administration com_associations Language & Strings
avatar Quy Quy - test_item - 3 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 3 Jan 2020

I have tested this item successfully on 0fba76d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27397.

avatar Quy
Quy - comment - 3 Jan 2020

Under Articles, here is one filter where - Select Featured - is in both places. Can we use COM_ASSOCIATIONS_SELECT_TARGET_LANGUAGE and not create a new one?

<div class="js-stools-field-filter">
				<span class="sr-only"><label id="filter_featured-lbl" for="filter_featured">
	- Select Featured -</label>
</span>
				<select id="filter_featured" name="filter[featured]" class="custom-select" onchange="this.form.submit();">
	<option value="" selected="selected">- Select Featured -</option>
			</div>
avatar brianteeman
brianteeman - comment - 3 Jan 2020

The strings are not the same

avatar Quy
Quy - comment - 3 Jan 2020

If that is the case, then the filters in Articles should be changed.

Select Featured (label)
- Select Featured - (dropdown)
avatar brianteeman
brianteeman - comment - 3 Jan 2020

I was lazy when I did that

avatar jwaisner jwaisner - test_item - 4 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 4 Jan 2020

I have tested this item successfully on 0fba76d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27397.

avatar Quy Quy - change - 4 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27397.

avatar rdeutz rdeutz - change - 4 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 4 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-04 14:59:57
Closed_By Quy
Labels Added: ? ?
avatar Quy Quy - close - 4 Jan 2020
avatar Quy Quy - merge - 4 Jan 2020
avatar brianteeman
brianteeman - comment - 4 Jan 2020

thanks

Add a Comment

Login with GitHub to post a comment