PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
22 Dec 2019

Pull Request for Issue #27307

Summary of Changes

This is reverting of #22757 which may cause loss of user data in specific cases, because of duplicate field names (group of fields).

Testing Instructions

Please look #27307 for detail

Expected result

You do not have duplicated field names

Actual result

You have duplicated field names

Documentation Changes Required

none

avatar Fedik Fedik - open - 22 Dec 2019
avatar Fedik Fedik - change - 22 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2019
Category JavaScript
avatar Fedik Fedik - change - 22 Dec 2019
The description was changed
avatar Fedik Fedik - edited - 22 Dec 2019
avatar ReLater ReLater - test_item - 22 Dec 2019 - Tested successfully
avatar ReLater
ReLater - comment - 22 Dec 2019

I have tested this item successfully on afcc5d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27334.

avatar viocassel viocassel - test_item - 23 Dec 2019 - Tested successfully
avatar viocassel
viocassel - comment - 23 Dec 2019

I have tested this item successfully on afcc5d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27334.

avatar Fedik Fedik - change - 23 Dec 2019
Labels Added: PR-staging
avatar Harmageddon
Harmageddon - comment - 23 Dec 2019

Is there a possibility to fix the issues that #22757 dealt with in another way? Or do we have to re-open #22441 and #22690? I agree that #22757 probably wasn't the best way to fix those, but if we swap one bug for another, it doesn't really help.

avatar Fedik
Fedik - comment - 23 Dec 2019

Is there a possibility to fix the issues that #22757 dealt with in another way?

Unfortunately there no easy way to do it, and practically there no much reason to spend a time for it.

I do not take that as a bug. it just a wish of perfectionists :)
In general, random row numbers does not lead to any functional issue.

Anyway it does not possible to keep "perfect numbering" after all. Add/remove/sort rows will break numbering.
I preparing similar pull request for j4, there may be will be possible 0,1,2.. numbering, but only until first remove/move.

I would mark that issues as "won't fix".

avatar Harmageddon
Harmageddon - comment - 23 Dec 2019

I see. Maybe one of @dawe78, @gaelicwinter, @continga can comment whether that was just a cosmetic change or a bug that needs fixing?

avatar ReLater
ReLater - comment - 26 Dec 2019
My Christmas wish

Dear Santa!

Regardless of further discussions. Please(!) don't hesitate merging this pr in 3.9.15 as-is and solve the other problem with another pr then.

This pr fixes a severe bug (data loss) and is already tested successfully.

avatar infograf768
infograf768 - comment - 26 Dec 2019

Was not aware @HLeithner modified his pseudo... 🤪

avatar Quy Quy - change - 26 Dec 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27334.

avatar HLeithner HLeithner - close - 26 Dec 2019
avatar HLeithner HLeithner - merge - 26 Dec 2019
avatar HLeithner HLeithner - change - 26 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-26 22:28:23
Closed_By HLeithner
Labels Added: RTC
avatar HLeithner
HLeithner - comment - 26 Dec 2019

Thanks

avatar continga
continga - comment - 7 Jan 2020

As far as I know #22757 fixed a bug, and not only a cosmetic change. Let us discuss this in #27342

avatar ReLater
ReLater - comment - 7 Jan 2020

Just a thought. Shouldn't this pr get a "Release Blocker"?

avatar wilsonge
wilsonge - comment - 7 Jan 2020

It's been merged so no :) Release blocker tags are a way for me and harald to track open issues/pr's that block us making a release

Add a Comment

Login with GitHub to post a comment