[#27334] - Fix subform with double field name
- Fixed in Code Base
- 26 Dec 2019
- Medium
- Build: staging
- # 27334
- Diff
- Fedik:fix-27307
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27307
Summary of Changes
This is reverting of #22757 which may cause loss of user data in specific cases, because of duplicate field names (group of fields).
Testing Instructions
Please look #27307 for detail
Expected result
You do not have duplicated field names
Actual result
You have duplicated field names
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27334.
| Labels |
Added:
?
|
||
Is there a possibility to fix the issues that #22757 dealt with in another way?
Unfortunately there no easy way to do it, and practically there no much reason to spend a time for it.
I do not take that as a bug. it just a wish of perfectionists :)
In general, random row numbers does not lead to any functional issue.
Anyway it does not possible to keep "perfect numbering" after all. Add/remove/sort rows will break numbering.
I preparing similar pull request for j4, there may be will be possible 0,1,2.. numbering, but only until first remove/move.
I would mark that issues as "won't fix".
I see. Maybe one of @dawe78, @gaelicwinter, @continga can comment whether that was just a cosmetic change or a bug that needs fixing?
My Christmas wish
Dear Santa!
Regardless of further discussions. Please(!) don't hesitate merging this pr in 3.9.15 as-is and solve the other problem with another pr then.
This pr fixes a severe bug (data loss) and is already tested successfully.
Was not aware @HLeithner modified his pseudo... ?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27334.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-26 22:28:23 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
Just a thought. Shouldn't this pr get a "Release Blocker"?
It's been merged so no :) Release blocker tags are a way for me and harald to track open issues/pr's that block us making a release
I have tested this item✅ successfully on afcc5d2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27334.