[#27333] - [4.0] Use icon to fix space in Help button
- Closed
- 27 Jan 2020
- Medium
- Build: 4.0-dev
- # 27333
- Diff
- Quy:25854-help-button
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25854 .
Summary of Changes
Change the help button to use icon- instead of fa- to be consistent with the other buttons.
Actions button has the same issue. There isn't an equivalent icon for it so it will be handled in a separate PR.
Testing Instructions
Go to Content > Articles
See space at the bottom of the Help button.
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Well that is not the case at the moment as icons in the toolbar except for Help and Action are icon-.
I am referring to this file
https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/scss/_icomoon.scss where most (should be all) of the icomoon fonts are mappes to fontawesome
So PR is fine as it and map fa-ellipsis-h to the mentioned file?
We have recently found out, that although they are indeed mapped, there are differences in padding.
Then we have to fix that in css. Just changing an icon is a bandaid solution
I'd check that the base styling .fa { ... } and .icon { ... } are the same.
To be honest, fa is still incorrect anyway as it's deprecated.
I can't replicate this issue using chrome on windows
but i can on firefox
Then all the other icons in the toolbar will have to be changed instead of this one only.
My experience of the issue is indeed in Firefox, not Safari for example (Macintosh)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-27 18:12:36 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
This can't be the correct solution. The entire point of using fontawesome was that it would replace the old icon- fonts and in many/most cases you will see that the icon- fonts are mapped to the fontawesome fonts.