PR-4.0-dev

Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
21 Dec 2019

Pull Request for Issue #25854 .

Summary of Changes

Change the help button to use icon- instead of fa- to be consistent with the other buttons.

Actions button has the same issue. There isn't an equivalent icon for it so it will be handled in a separate PR.

Testing Instructions

Go to Content > Articles
See space at the bottom of the Help button.

Actual result

62202085-89c3b100-b380-11e9-83f2-f82cb5a37ff9

avatar Quy Quy - open - 21 Dec 2019
avatar Quy Quy - change - 21 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2019
Category Libraries
avatar brianteeman
brianteeman - comment - 21 Dec 2019

This can't be the correct solution. The entire point of using fontawesome was that it would replace the old icon- fonts and in many/most cases you will see that the icon- fonts are mapped to the fontawesome fonts.

avatar Quy
Quy - comment - 21 Dec 2019

Well that is not the case at the moment as icons in the toolbar except for Help and Action are icon-.

avatar brianteeman
brianteeman - comment - 21 Dec 2019

I am referring to this file
https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/system/scss/_icomoon.scss where most (should be all) of the icomoon fonts are mappes to fontawesome

avatar Quy
Quy - comment - 22 Dec 2019

So PR is fine as it and map fa-ellipsis-h to the mentioned file?

avatar infograf768
infograf768 - comment - 22 Dec 2019

We have recently found out, that although they are indeed mapped, there are differences in padding.

avatar brianteeman
brianteeman - comment - 22 Dec 2019

Then we have to fix that in css. Just changing an icon is a bandaid solution

avatar C-Lodder
C-Lodder - comment - 22 Dec 2019

I'd check that the base styling .fa { ... } and .icon { ... } are the same.
To be honest, fa is still incorrect anyway as it's deprecated.

avatar brianteeman
brianteeman - comment - 22 Dec 2019

I can't replicate this issue using chrome on windows
image

image

but i can on firefox

avatar Quy
Quy - comment - 22 Dec 2019

Then all the other icons in the toolbar will have to be changed instead of this one only.

avatar C-Lodder
C-Lodder - comment - 22 Dec 2019

@Quy The whole of core should be using fa[b|r|s] fa-xxx.
icon-xxx is only mapped for 3rd party extensions to keep B/C

avatar infograf768
infograf768 - comment - 23 Dec 2019

My experience of the issue is indeed in Firefox, not Safari for example (Macintosh)

avatar Quy
Quy - comment - 27 Jan 2020

Closing. It will be fixed in #27657.

avatar Quy Quy - close - 27 Jan 2020
avatar Quy Quy - change - 27 Jan 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-01-27 18:12:36
Closed_By Quy
Labels Added: PR-4.0-dev

Add a Comment

Login with GitHub to post a comment