[#26838] - [4.0] drop unused assets
- Closed
- 30 Oct 2019
- Medium
- Build: 4.0-dev
- # 26838
- Diff
- dgrammatiko:4.0-dev-drop-unused-assets
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Drop some legacy, unused scripts
Info
- sortablelist has been replaced by dragula
- ajax-chosen and chosen has been replaced by fancy-select
- tab-state has been replaced by Joomla-tabs
- recaptcha just removed the minified version and renamed it to .es5.js so the build tools will reminify it
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript |
shouldn't we keep the legacy scripts so that non-core extensions don't have to rewrite everything
Well, if that is the case then we did a really bad job when we used the old HTMLHelper API to wire the new scripts with the old end points
I don't think the tabs custom element does keep the state across requests does it?
Agree with @dgrammatiko that if we have existing HtmlHelper scripts rewire to things that are largely b/c this is ok.
I don't think the tabs custom element does keep the state across requests does it?
I think it does. What it doesn't do is let you link to a tab see
#25359
Agree with @dgrammatiko that if we have existing HtmlHelper scripts rewire to things that are largely b/c this is ok.
Thats great to hear
I don't think the tabs custom element does keep the state across requests does it?
In theory it does. I mean the code initially covered these scenarios:
- local storage data from a previous visited page (same regex as in tab state)
- activation of a tab through a url hash (eg some-url#tab1)
activation of a tab through a url hash (eg some-url#tab1)
This does not work.
Sortablelist is used
Uhhhh, my bad
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-30 19:39:31 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
NPM Resource Changed
?
|
||
you're going to hate me for this - shouldn't we keep the legacy scripts so that non-core extensions don't have to rewrite everything?