? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
27 Oct 2019

Summary of Changes

As title says

Testing Instructions

Install a clean 4.0-dev.
Install Persian language and switch to Persian in back-end

Display Article Manager, select an article, click on the Actions button to see dropdown.
Look at the Searchtools Clear button margins.

Patch and run npm.

Display Installed Languages manager and look at Clear button margins

Before patch

Screen Shot 2019-10-27 at 10 42 54

Screen Shot 2019-10-27 at 10 42 46

After patch

Screen Shot 2019-10-27 at 10 45 02

Screen Shot 2019-10-27 at 10 44 52

avatar infograf768 infograf768 - open - 27 Oct 2019
avatar infograf768 infograf768 - change - 27 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2019
Category Administration Templates (admin)
avatar infograf768 infograf768 - change - 27 Oct 2019
The description was changed
avatar infograf768 infograf768 - edited - 27 Oct 2019
avatar infograf768
infograf768 - comment - 27 Oct 2019

Note for css specialists

The searchtools css/scss are extremely confusing.
We have an instance in atum/scss/blocks/_searchtools.scss
and in build/media_source/system/css/searchtools.css

Their loading order as well as redundancies are a pain to deal with.
Do we really need to keep both? I guess that in any case a custom admin template would create its own scss if judged necessary.
Using only the atum scss one would help a lot.

avatar dgrammatiko
dgrammatiko - comment - 27 Oct 2019

Using only the atum scss one would help a lot.

The right thing is to use the other one from media. Also as this needs some touches to integrate to the Atum styles then an override needs to be created, eg the file atum/scss/blocks/_searchtools.scss needs to be renamed to atum/scss/system/searchtools.scss (of course it still needs to @import the original one there). Check #26077 The way this was done is leading to a monolith css file which is nowhere near to the current best practices (modularised assets)

avatar infograf768
infograf768 - comment - 27 Oct 2019

@dgrammatiko
the one from media (css) is using for example
@media (max-width: 480px) {
while the atum scss one is using
@include media-breakpoint-down(sm) from bootstrap which equivalent to 576px....(defined in bootstrap map).

The resulting css may be
@media (max-width: 575.98px) { which may be defined in //media/vendor/bootstrap/scss/mixins/_breakpoints.scss taking off -.02

This is totally over my head. This should be the task of someone who knows better the stuff.
I can only deal with what we have now and try to do the rtl as nobody takes care of that.

As for touch ups, we should get first something stable including rtl whatever files they are.

avatar infograf768 infograf768 - change - 27 Oct 2019
Labels Added: ?
avatar wilsonge wilsonge - close - 31 Oct 2019
avatar wilsonge wilsonge - merge - 31 Oct 2019
avatar wilsonge wilsonge - change - 31 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-31 08:57:47
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment