? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
24 Oct 2019

Pull Request for Issue #26782 .

Summary of Changes

Set also modified date for new redirect links because that database column does not have a default value anymore.

Testing Instructions

See issue #26782 .

Has to be tested on MySQL 8 or an earlier version where strict mode is switched on.

Expected result

No error, redirect link is created.

Actual result

Error "500 PLG_SYSTEM_REDIRECT_ERROR_UPDATING_DATABASE".

Documentation Changes Required

None.

avatar richard67 richard67 - open - 24 Oct 2019
avatar richard67 richard67 - change - 24 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2019
Category Front End Plugins
avatar richard67
richard67 - comment - 24 Oct 2019

@wilsonge I fear that we have such problems elsewhere, too, where we have removed default values from not nullable datetime columns. I'll have to check on weekend whereever inserts are done in such tables in that way, i.e. not using the table class of that component's table but the insertObject method of the Db driver. Or am I wrong?

avatar waader waader - test_item - 24 Oct 2019 - Tested successfully
avatar waader
waader - comment - 24 Oct 2019

I have tested this item successfully on c592189

That works, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26799.

avatar alikon alikon - test_item - 24 Oct 2019 - Tested successfully
avatar alikon
alikon - comment - 24 Oct 2019

I have tested this item successfully on c592189


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26799.

avatar alikon alikon - change - 24 Oct 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 24 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26799.

avatar wilsonge wilsonge - change - 25 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-25 15:05:37
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 25 Oct 2019
avatar wilsonge wilsonge - merge - 25 Oct 2019
avatar wilsonge
wilsonge - comment - 25 Oct 2019

Thanks!

Possible we have broken things in other places but that's just kinda life - we can fix it as it comes. That's why we have alpha's and beta's and rc's to catch the edge cases.

avatar richard67
richard67 - comment - 25 Oct 2019

I'll work on weekend on it and make PRs if necessary.

avatar richard67
richard67 - comment - 25 Oct 2019

@wilsonge It seems we are lucky: I found no other use of the db driver's InsertObject with any table where we have the problem handled here for inserting new redirect links.

Add a Comment

Login with GitHub to post a comment