? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Oct 2019

In #26797 I created a global string for "Name ascending" and "Name descending"

This PR uses that global string instead of duplicating the string in each component

testing

This can be tested without #26797 its just that the sort option will be displayed as JGLOBAL_NAME_ASC instead of "Name ascending"

avatar brianteeman brianteeman - open - 24 Oct 2019
avatar brianteeman brianteeman - change - 24 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2019
Category Administration com_banners com_installer com_users Language & Strings
avatar Quy
Quy - comment - 24 Oct 2019

Also update:
System > Update > Extensions
System > Update > Update Sites

avatar brianteeman brianteeman - change - 24 Oct 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 24 Oct 2019

@Quy done

avatar Quy Quy - test_item - 24 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 24 Oct 2019

I have tested this item successfully on 0937049


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26798.

avatar joeykrop joeykrop - test_item - 25 Oct 2019 - Tested successfully
avatar joeykrop
joeykrop - comment - 25 Oct 2019

I have tested this item successfully on 0937049


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26798.

avatar Quy Quy - change - 25 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Oct 2019

RFC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26798.

avatar wilsonge wilsonge - change - 25 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-25 22:06:02
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Oct 2019
avatar wilsonge wilsonge - merge - 25 Oct 2019
avatar wilsonge
wilsonge - comment - 25 Oct 2019

Thanks!

avatar brianteeman
brianteeman - comment - 25 Oct 2019

Thanks

Add a Comment

Login with GitHub to post a comment