[#26800] - [4.0] Enabling SCSS linting
- Closed
- 7 Dec 2019
- Medium
- Build: 4.0-dev
- # 26800
- Diff
- Hackwar:patch-25
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
For some reason, Hound doesn't lint our SCSS. This is an attempt to enable that. Lets see if this blows up spectacularly now.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Labels |
Added:
?
?
|
||
I actually don't want any exclusions. Why should we exclude anything? In any case, we currently don't seem to have any linting at all...
You should not be linting anything in the node_modules directory. So this needs to be excluded.
As the node_modules folder is not part of our repo and the config explicitly states scss files, we should be fine.
Keep in mind that Hound will only review/monitor the changes in the pull request.
Closing this one, since my assumption seems to have been wrong. Hound does indeed only lint those files which were changed and since we didn't change all files lately, that would explain that... Anyway, changing this here would be an unnecessary change, thus closing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-07 12:19:47 |
| Closed_By | ⇒ | Hackwar |
Don't forget to add the exclusions