Feeling Lucky
NPM Resource Changed
?
[#26385] - [4.0] Better error handling in com_finder/sample data
- Fixed in Code Base
- 23 Sep 2019
- Medium
- Build: 4.0-dev
- # 26385
- Diff
- wilsonge:fix/debug-sample
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26036 (not a patch but better error handling).
Summary of Changes
Adds better error handling in two place
- The plugin itself - now if non-json responses come back due to PHP errors then the plugin will now display a pretty notice and stop showing loading forever
- Taxonomy. Something is very wrong in finder @Hackwar . Seems very related to #26235 - stuff in taxonomy tables seems either missing or incomplete - only one category out of them all was showing in the table itself.
Testing Instructions
Install sample data
- Optionally comment out the new code in the taxonomy table. Install sample data, see the error message that the response is invalid (note the english in that message is not great - but is an existing string so is outside scope of this PR - i'm sure @brianteeman will patch that)
- (if step 1 was performed commenting out the finder error handling then undo that) Install sample data - see error message about nodes not existing in the smart search taxonomy table.
Expected result
Error handling not causing sample data plugins to stall
Actual result
Error handling is in place both for the actual issue we currently have in finder and also for any future things in the modules javascript
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-23 22:42:27 |
| Closed_By | ⇒ | wilsonge |