Feeling Lucky
Conflicting Files
?
[#26384] - [4.0] Fix some typehints in finder plugins to namespaced versions
- Closed
- 17 May 2021
- Medium
- Build: 4.0-dev
- # 26384
- Diff
- wilsonge:fix/finder-namespace
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr Build is failing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Change typehints + unnamepsaced class usage to namespaced class usage
Testing Instructions
Code reiew
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Front End Plugins |
| Title |
|
||||||
| Labels |
Added:
?
|
||
richard67
- comment
- 25 Sep 2019
LGTM. But shouldn't the descriptions not be changed, too, like Quy mentioned? I.e.
@param Table $row A JTable object => @param Table $row A Table object
and so on?
Hackwar
- comment
- 17 May 2021
yes
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-17 17:23:54 |
| Closed_By | ⇒ | richard67 |
I have tested this item✅ successfully on 75d3c08
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26384.