[#26300] - [4.0] Separate core.js into multiple files
- Fixed in Code Base
- 26 Apr 2020
- Medium
- Build: 4.0-dev
- # 26300
- Diff
- HLeithner:explode-js
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Do NO SQUASH merge this commit please.
There are 2 reasons for this PR. First get core.js more module and split into multiple files for better maintainability. The second is a copyright issue reported by @brianteeman for the webcomponents part of the core.js
Summary of Changes
Make it possible to split concat javascript files into a main file based on the directory name.
Add change history in git commits to preserve copyright and change information.
Testing Instructions
you need to run npm install,
test Joomla core functionality like
- javascript translations
- check error messages creation in forms / ajax forms
- check webcomponents loaded correctly
Expected result
works
Actual result
works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I think you are also missing this:
// Only define the Joomla namespace if not defined.
window.Joomla = window.Joomla || {};
I think you are also missing this:
// Only define the Joomla namespace if not defined. window.Joomla = window.Joomla || {};
This is in the core.es6.js file in line 7.
@HLeithner can you resolve the conflicts so we can get this merged and resolve the copyright issue please
| Labels |
Added:
Conflicting Files
|
||
I will try to resolve this when I have time... it's a bit more work then expected...
@HLeithner friendly reminder on this one
@HLeithner could you resolve the conflicts please so that we can get this merged and resolve the copyright issue asap
@HLeithner @wilsonge I am marking this as a beta blocker because of the copyright issue
| Labels |
Added:
?
|
||
I have tested this item
Functionality works as expected after applying the PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26300.
@HLeithner Drone is failing in MySQL and JS. Can you take a look to see if it is related to your PR?
| Labels |
Removed:
Conflicting Files
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26300.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26300.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26300.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-26 13:41:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thankyou for dealing with this @HLeithner !
Finally YaY thanks!
Thanks for dealing with this.