[#26299] - [4.0] Missing language strings in installer
- Closed
- 5 Nov 2020
- Medium
- Build: master
- # 26299
Steps to reproduce the issue
- Install an extension that you know will fail the installation
- Notice you get a popup with a message like this:
The issue is that we have this code in the installer 'JLIB_INSTALLER_' . $this->route but there are no translations for them.
We need to find out which routes we have, to know which messages we need.
Expected result
The message is translated
Actual result
The message is untranslated
Additional comments
I am putting this issue here as a reminder so we don't forget about them
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Labels |
Added:
J4 Issue
|
||
| Status | New | ⇒ | Discussion |
zero-24
- | Title |
|
||||||
@brianteeman I am not sure it is specific to J4 as I did not look at J3, I just ran into this and wanted to make sure we don't forget about it.
I have had a look at this issue by searching the code for occurrences of JLIB_INSTALLER_' and I think there is only one string missing: JLIB_INSTALLER_DISCOVER_INSTALL and it is the same in J3. I could do a PR for J4. However, I don't know how to test it. Clearly I need to unpack a component and discover it. I tried that with the search component from J3 and it installed. I don't know how to set the PHP minimum requirement as suggested by the screenshot above. Also, I noticed that a lot of the instances of JLIB_INSTALLER_ were not followed by strtoupper - in ModuleAdapter.php, PackageAdapter.php, PluginAdapter.php and more. Should that be a separate issue? Or does it not matter?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26299.
alikon
- | Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-05 17:28:26 |
| Closed_By | ⇒ | alikon |
@roland-d are you sure that this is specific to Joomla 4 as it looks the same code as in joomla 3